GUI fixes#1560
Merged
Merged
Conversation
Prevent Tk labelwidget parent mismatches in project opener/creator windows by creating section labels with self.main_frame as parent.
Fix Tk image lifecycle issues in the base window to avoid icon/image fallback and missing-image runtime errors: - keep a persistent PhotoImage reference for window iconphoto - bind buffered PhotoImage instances to the target parent widget
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR applies small but important Tkinter GUI fixes to ensure widgets/images are correctly parented and to prevent image/icon objects from being garbage-collected.
Changes:
- Pass explicit masters/parents to
ttk.Labelandtk.PhotoImageto stabilize widget hierarchy. - Preserve the application icon
PhotoImagereference to avoid Tkinter icon disappearing. - Update a frontend unit test to match the new
PhotoImage(master=..., ...)call signature.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/test_frontend_tkinter_base_window.py |
Updates assertion to match PhotoImage being created with an explicit master. |
ardupilot_methodic_configurator/frontend_tkinter_project_opener.py |
Sets explicit parent for option header labels used for LabelFrame headers. |
ardupilot_methodic_configurator/frontend_tkinter_project_creator.py |
Sets explicit parent for the option header label used for a LabelFrame header. |
ardupilot_methodic_configurator/frontend_tkinter_base_window.py |
Keeps icon PhotoImage alive via an instance attribute and parents PhotoImage instances to the correct widget. |
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Misc GUI fixes
Checklist
git commit --signoff)Testing
Describe how you tested these changes: