-
Notifications
You must be signed in to change notification settings - Fork 64
Simplify re init #1561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Simplify re init #1561
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
7f211b4
refactor(filesystem): rename functions to improve consistency
amilcarlucas 3b15ccf
fix(filesystem): default parameters do not belong in the file_paramet…
amilcarlucas 01d1ceb
docs(usecases): Add missing Infer component specifications and FC con…
amilcarlucas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -984,17 +984,26 @@ def merge_forced_or_derived_parameters( | |||||||||||||||||||
| dest[param_name] = param | ||||||||||||||||||||
| return at_least_one_param_changed | ||||||||||||||||||||
|
|
||||||||||||||||||||
| def write_param_default_values(self, param_default_values: ParDict) -> bool: | ||||||||||||||||||||
| def set_param_default_values_if_different(self, param_default_values: ParDict) -> bool: | ||||||||||||||||||||
| """ | ||||||||||||||||||||
| Set the default parameter values if they are different from the current ones. | ||||||||||||||||||||
|
|
||||||||||||||||||||
| Args: param_default_values: A ParDict containing the default parameter values to compare against the current ones. | ||||||||||||||||||||
| Returns: bool: True if the default parameter values were updated, False if they were the same as the current ones. | ||||||||||||||||||||
| """ | ||||||||||||||||||||
| param_default_values = ParDict(dict(sorted(param_default_values.items()))) | ||||||||||||||||||||
| if self.param_default_dict != param_default_values: | ||||||||||||||||||||
| self.param_default_dict = param_default_values | ||||||||||||||||||||
| return True | ||||||||||||||||||||
| return False | ||||||||||||||||||||
|
|
||||||||||||||||||||
| def write_param_default_values_to_file(self, param_default_values: ParDict, filename: str = "00_default.param") -> None: | ||||||||||||||||||||
| if self.write_param_default_values(param_default_values): | ||||||||||||||||||||
| self.file_parameters[filename] = param_default_values | ||||||||||||||||||||
| self.param_default_dict.export_to_param(os_path.join(self.vehicle_dir, filename)) | ||||||||||||||||||||
| def write_param_default_values_to_file( | ||||||||||||||||||||
| self, param_default_values: ParDict, filename: str = "00_default.param", vehicle_dir: str = "" | ||||||||||||||||||||
| ) -> None: | ||||||||||||||||||||
| if self.set_param_default_values_if_different(param_default_values): | ||||||||||||||||||||
| if len(vehicle_dir) == 0: | ||||||||||||||||||||
| vehicle_dir = self.vehicle_dir | ||||||||||||||||||||
|
Comment on lines
+1001
to
+1005
|
||||||||||||||||||||
| self, param_default_values: ParDict, filename: str = "00_default.param", vehicle_dir: str = "" | |
| ) -> None: | |
| if self.set_param_default_values_if_different(param_default_values): | |
| if len(vehicle_dir) == 0: | |
| vehicle_dir = self.vehicle_dir | |
| self, param_default_values: ParDict, filename: str = "00_default.param", vehicle_dir: Optional[str] = None | |
| ) -> None: | |
| if self.set_param_default_values_if_different(param_default_values): | |
| vehicle_dir = vehicle_dir or self.vehicle_dir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.