Add BDD tests for about popup, bin log selection, derived params, and connection renaming#1639
Open
amilcarlucas wants to merge 2 commits into
Open
Add BDD tests for about popup, bin log selection, derived params, and connection renaming#1639amilcarlucas wants to merge 2 commits into
amilcarlucas wants to merge 2 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| assert isinstance(call_args, str), f"Expected URL string but got {type(call_args)}" | ||
| call_args_lower = call_args.lower() | ||
| assert "issues" in call_args_lower or "bug" in call_args_lower, f"Issues URL not found in {call_args}" | ||
| assert "github.com" in call_args_lower, f"GitHub URL not found in {call_args}" |
Contributor
Contributor
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Coverage Report for CI Build 26404779401Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.1%) to 96.823%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
amilcarlucas
force-pushed
the
more_tests
branch
2 times, most recently
from
86ff36f to
f2a4efa
Compare
Comment on lines
+26
to
+34
| @pytest.fixture | ||
| def root() -> Generator[tk.Tk, None, None]: | ||
| """Provide a hidden Tk root window for tests.""" | ||
| root = tk.Tk() | ||
| root.withdraw() | ||
| yield root | ||
| root.update_idletasks() | ||
| root.destroy() | ||
|
|
| "ardupilot_methodic_configurator.frontend_tkinter_base_window.BaseWindow._get_dpi_scaling_factor", | ||
| return_value=1.0, | ||
| ), | ||
| patch("ardupilot_methodic_configurator.frontend_tkinter_base_window.BaseWindow.center_window"), |
Comment on lines
+212
to
+218
| def setUp(self) -> None: | ||
| self.root = tk.Tk() | ||
| self.root.withdraw() | ||
|
|
||
| def tearDown(self) -> None: | ||
| self.root.update_idletasks() | ||
| self.root.destroy() |
…ms, and connection renaming - Add TestAboutWindowCreation, TestAboutWindowButtonInteractions, TestAboutWindowUsagePopupPreferences in new test file - Add TestBinLogSelectionWidgets covering success, cancel, and all error paths (VehicleProjectCreationError, VehicleProjectOpenError, OSError) - Add TestDerivedParametersFiltering covering FC-filtered, file-filtered, and offline (no FC) scenarios - Add TestConnectionRenamingWithSameNameSkip covering no-op and conflict cases Quality: - Assert mock_set is called when toggling usage popup checkbox (was vacuous) - _find_button_by_text raises AssertionError with diagnostics if not found - Replace 6-tuple wildcard unpacking with named variables - Assert _duplicates == set() in rename tests - Replace unused bin_log_widget_setup fixture with _make_widget() helper to eliminate duplicated widget construction in every test method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quality:
Checklist
git commit --signoff)Testing
Describe how you tested these changes: