Add motor diagrams in png format as the svg is complicated to render#762
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds new scripts to convert SVG motor diagrams to PNG format to address rendering complexities. The motivation is that SVG files are complicated to render, so pre-rendered PNG versions provide better consistency and performance.
Key changes:
- Adds interactive SVG viewer application for previewing motor diagrams
- Adds batch conversion script to process all motor diagrams from SVG to PNG format
- Uses Firefox-geckodriver for high-quality SVG rendering with image processing pipeline
Reviewed Changes
Copilot reviewed 2 out of 45 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| scripts/motor_diagrams_viewer_app.py | Interactive Tkinter GUI application for viewing and comparing SVG motor diagrams with size information |
| scripts/batch_convert_motor_diagrams.py | Batch conversion utility that processes all motor diagram SVGs to optimized 200x200 PNG files |
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Contributor
Test Results 2 files 2 suites 1m 22s ⏱️ Results for commit 35fa2d4. ♻️ This comment has been updated with latest results. |
amilcarlucas
force-pushed
the
png_motor_diagrams
branch
from
8ca8e01 to
35fa2d4
Compare
amilcarlucas
force-pushed
the
png_motor_diagrams
branch
2 times, most recently
from
7124bd1 to
9856b7c
Compare
…complicated to render
amilcarlucas
force-pushed
the
png_motor_diagrams
branch
from
d75f0e6 to
7405bde
Compare
for more information, see https://pre-commit.ci
amilcarlucas
force-pushed
the
png_motor_diagrams
branch
from
eda85b4 to
1a8fbca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new scripts to convert SVG motor diagrams to PNG format to address rendering complexities. The motivation is that SVG files are complicated to render, so pre-rendered PNG versions provide better consistency and performance.