Skip to content

Scroll with mouse wheel does not work over labels and text fields in components and in parameters #460#764

Merged
amilcarlucas merged 4 commits into
ArduPilot:masterfrom
Trishanshv:fix-win-icon-460
Sep 4, 2025
Merged

Scroll with mouse wheel does not work over labels and text fields in components and in parameters #460#764
amilcarlucas merged 4 commits into
ArduPilot:masterfrom
Trishanshv:fix-win-icon-460

Conversation

@Trishanshv
Copy link
Copy Markdown
Contributor

This PR fixes an issue where the main window would not scroll when the mouse cursor was hovering over child widgets like text entries (ttk.Entry) and labels. #460
This implementation adopts the improved approach suggested by @amilcarlucas in the issue comments.
Closes #460.

Note: The test_user_benefits_from_consistent_ui_styling test appears to be failing on the main branch and is unrelated to these changes.

@amilcarlucas
Copy link
Copy Markdown
Collaborator

Thanks, but there is something very wrong with you commit. It adds 2621000 lines of code. And countless files.
Please fix that.

@Trishanshv Trishanshv force-pushed the fix-win-icon-460 branch 2 times, most recently from ed062a2 to fa47188 Compare September 3, 2025 16:22
@Trishanshv
Copy link
Copy Markdown
Contributor Author

Sorry for all the extra commits earlier, @amilcarlucas. This is my first pull request, and I was a bit nervous, so I made a mistake with the commit history.
I've now cleaned it up so it's just a single commit with the fix. Please take another look when you have a chance.

amilcarlucas
amilcarlucas previously approved these changes Sep 4, 2025
@amilcarlucas amilcarlucas merged commit 368b9e5 into ArduPilot:master Sep 4, 2025
13 of 17 checks passed
@amilcarlucas
Copy link
Copy Markdown
Collaborator

@Trishanshv thanks for contributing. Merged

@Trishanshv Trishanshv deleted the fix-win-icon-460 branch September 6, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scroll with mouse wheel does not work over labels and text fields in components and in parameters

2 participants