Add low wind warning#771
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds important safety warnings about wind conditions when using ArduPilot's Quicktune feature. The warning alerts users that Quicktune requires moderate wind disturbances to calibrate properly and warns against flying in calm conditions.
- Adds critical safety warning about wind requirements for Quicktune calibration
- Warns users about potential dangers of using Quicktune in calm conditions
- Prevents potential crashes from overly aggressive PID values
Comment on lines
+785
to
+788
| WARNING: Quicktune requires moderate wind disturbances to calibrate properly. | ||
| Flying in completely calm conditions or perfectly steady wind can cause Quicktune to calculate overly aggressive PID values. | ||
| These excessive settings may cause dangerous oscillations and potential crashes when your vehicle later encounters normal wind conditions. | ||
|
|
There was a problem hiding this comment.
The same warning text is duplicated at lines 785-787 and 866-868. Consider creating a single, prominently placed warning section to avoid duplication and ensure consistency if the warning needs to be updated in the future.
Suggested change
| WARNING: Quicktune requires moderate wind disturbances to calibrate properly. | |
| Flying in completely calm conditions or perfectly steady wind can cause Quicktune to calculate overly aggressive PID values. | |
| These excessive settings may cause dangerous oscillations and potential crashes when your vehicle later encounters normal wind conditions. | |
| ## Quicktune Wind Warning | |
| **WARNING:** Quicktune requires moderate wind disturbances to calibrate properly. | |
| Flying in completely calm conditions or perfectly steady wind can cause Quicktune to calculate overly aggressive PID values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.