AMC-975: Allow to select supported vehicle and to skip telemetry radi…

[flyasky]

…o as another system on the same connection

Possible fix for #975
pushed with --no-verify

pylint..........................................................................Failed
- hook id: pylint
- exit code: 1

Failed to canonicalize script path

mypy............................................................................Failed
- hook id: mypy
- exit code: 1

[Copilot]

Pull Request Overview

This PR enhances the MAVLink connection logic to detect multiple vehicles on the same connection and handle unsupported autopilot types more gracefully. Instead of failing immediately when an unsupported vehicle is detected, the system now continues searching for a supported vehicle within the timeout period.

Key Changes:

• Modified heartbeat detection to collect all vehicles detected within the timeout window
• Changed behavior to skip unsupported autopilot types instead of returning an error immediately
• Updated logging messages to reflect the multi-vehicle detection capability

Comments suppressed due to low confidence (1)

ardupilot_methodic_configurator/backend_flightcontroller.py:493

• The loop continues when an unsupported autopilot is found but never breaks or returns when a supported autopilot is found. This means after processing a supported vehicle, the code falls through to line 498 and beyond, but self.info state may be set incorrectly if multiple vehicles were detected. The loop should explicitly break after line 493 for a supported vehicle, or return success at that point.

            for (sysid, compid), m in detected_vehicles.items():
                self.info.set_system_id_and_component_id(sysid, compid)
                logging_debug(
                    _("Connection established with systemID %d, componentID %d."), self.info.system_id, self.info.component_id
                )
                self.info.set_autopilot(m.autopilot)
                if self.info.is_supported:
                    msg = _("Autopilot type {self.info.autopilot}")
                    logging_info(msg.format(**locals()))
                else:
                    msg = _("Unsupported autopilot type {self.info.autopilot}")
                    # return msg.format(**locals())
                    continue

                self.info.set_type(m.type)
                msg = _("Vehicle type: {self.info.mav_type} running {self.info.vehicle_type} firmware")
                logging_info(msg.format(**locals()))

[Copilot]

After the loop completes (line 477-494), there's no handling for the case where all detected vehicles are unsupported. The code should return an error message after the loop if no supported vehicle was found, otherwise it will continue to line 498 with potentially incorrect vehicle state.

[Copilot]

Commented-out code should be removed rather than left in the codebase. If this is temporary for debugging or comparison, add a TODO comment explaining why it's retained.

Suggested change

# return msg.format(**locals())

[amilcarlucas]

Thanks for your contribution.
I corrected the linting issues, squashed the commits and rewrote the commit message to obey conventional commits standards.

[amilcarlucas]

Tested in windows, works for both udp and tcp