Skip to content

frontend(tkinter): add clickable link to tuning guide in step 11 dialog#995

Merged
amilcarlucas merged 2 commits into
ArduPilot:masterfrom
neo-0007:feat/add_link_to_docs
Oct 30, 2025
Merged

frontend(tkinter): add clickable link to tuning guide in step 11 dialog#995
amilcarlucas merged 2 commits into
ArduPilot:masterfrom
neo-0007:feat/add_link_to_docs

Conversation

@neo-0007

@neo-0007 neo-0007 commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

When transitioning from Step 11 (initial ATC PID tuning) to Step 12, if "Automatically open documentation links..." is disabled, the popup message previously mentioned the tuning guide but did not provide any clickable links, which was confusing to users.

This change adds a blue, underlined "Open Tuning Guide" label that opens the relevant ArduPilot tuning instructions page in the default web browser

Issue: #951

Before :
image

After :
after_change

Copilot AI review requested due to automatic review settings October 29, 2025 07:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a clickable hyperlink to the tuning guide in a dialog that prompts users about copying flight controller values to a file after external configuration changes. The link provides quick access to relevant documentation about the experimental procedure.

Key Changes

  • Added a clickable "Open Tuning Guide" link with appropriate styling (blue, underlined, hand cursor)
  • The link opens a specific section of the ArduCopter tuning guide related to initial attitude PID gains

Comment thread ardupilot_methodic_configurator/frontend_tkinter_parameter_editor.py Outdated
Comment thread ardupilot_methodic_configurator/frontend_tkinter_parameter_editor.py Outdated
@amilcarlucas

Copy link
Copy Markdown
Collaborator

This very same dialog is used in other places in the configuration sequence.
So the URL needs to be open using configuration_manager.py:1431 open_documentation_in_browser(selected_file) method.

@amilcarlucas amilcarlucas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please sign-off the commits

Comment thread ardupilot_methodic_configurator/frontend_tkinter_parameter_editor.py Outdated
Comment thread ardupilot_methodic_configurator/frontend_tkinter_parameter_editor.py Outdated
@neo-0007 neo-0007 force-pushed the feat/add_link_to_docs branch from 7b84864 to e4f658d Compare October 29, 2025 08:21
@neo-0007

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback! I’ve made the requested changes and pushed the updated code.
I also updated the commit message to follow the conventional commits format and added the signed-off-by line.
Please let me know if any further adjustments are needed.

Comment thread ardupilot_methodic_configurator/frontend_tkinter_parameter_editor.py Outdated
@neo-0007 neo-0007 force-pushed the feat/add_link_to_docs branch from edb9a5f to bcc6289 Compare October 29, 2025 16:23
When transitioning from Step 11 (initial ATC PID tuning) to Step 12,
if "Automatically open documentation links..." is disabled, the popup
message previously mentioned the tuning guide but did not provide any
clickable links, which was confusing to users.

This change adds a blue, underlined "Open Tuning Guide" label that
opens the relevant ArduPilot tuning instructions page in the default
web browser

Closes ArduPilot#951

Signed-off-by: neo-0007 <hrishikeshgohain123@gmail.com>
@neo-0007 neo-0007 force-pushed the feat/add_link_to_docs branch from bcc6289 to 59d4a23 Compare October 29, 2025 16:28
amilcarlucas
amilcarlucas previously approved these changes Oct 29, 2025
Used the safe font
Correct a documentation link


Signed-off-by: Dr.-Ing. Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
@amilcarlucas amilcarlucas force-pushed the feat/add_link_to_docs branch from 2b1d931 to 66be939 Compare October 30, 2025 00:49
@amilcarlucas amilcarlucas merged commit aa7a40b into ArduPilot:master Oct 30, 2025
14 checks passed
@amilcarlucas

Copy link
Copy Markdown
Collaborator

Thanks for the code, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants