webadmin: don't put the Generate button on the login page#38
Merged
Conversation
LoginForm.passphrase and AdminAddForm.passphrase are both named
"passphrase", so WTForms renders both with id="passphrase". The
add-form Generate-button hook used getElementById('passphrase'),
which matched the login form too — a passphrase generator showed up
on the login page, which makes no sense there.
Scope attachAddFormGenerator() to the form.admin-add-form on the
admin list page (the class was already on that <form>); the login
page has no such form, so the button no longer appears there.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoginForm.passphrase and AdminAddForm.passphrase are both named "passphrase", so WTForms renders both with id="passphrase". The add-form Generate-button hook used getElementById('passphrase'), which matched the login form too — a passphrase generator showed up on the login page, which makes no sense there.
Scope attachAddFormGenerator() to the form.admin-add-form on the admin list page (the class was already on that
); the login page has no such form, so the button no longer appears there.