AP_GPS: Fix DNU constant values in AP_GPS_SBF.cpp#32642
Conversation
|
Hi @UAVcihang, Thanks for this. Could you fix the commit title to start with "AP_GPS:"? Also it appears that you didn't use the PR template for some reason. In any case, can you clarify what testing has been done? |
yes |
| static bool is_DNU(double value) | ||
| { | ||
| constexpr double DNU = -2e10f; | ||
| constexpr double DNU = -2e+10f; |
There was a problem hiding this comment.
What does this accomplish?
| check_new_itow(temp.TOW, sbf_msg.length); | ||
|
|
||
| constexpr double floatDNU = -2e-10f; | ||
| constexpr double floatDNU = -2e+10f; |
There was a problem hiding this comment.
We could also probably profit to drop the 'f' qualifier since we are using true double.
|
|
||
| // just breakout any consts we need for Do Not Use (DNU) reasons | ||
| constexpr double doubleDNU = -2e-10; | ||
| constexpr double doubleDNU = -2e+10; |
|
@UAVcihang rapid iteration here would be appreciated; we should get this into the next 4.7 beta |
CraigElder
changed the title
|
change is correct |
peterbarker
force-pushed
the
patch-2
branch
2 times, most recently
from
676dc5e to
56721dc
Compare
|
@UAVcihang thanks for this! We've gone ahead and made changes live on devcall for this one :-) Marking for merge |
|
We've merged this one - thanks @UAVcihang |
|
This has been included in 4.7.0-beta4. Thanks! |
7 participants
https://github.com/ArduPilot/ardupilot/commit/f11b98d42214b845338fb7ed3494793c9bdbbcf3