AP_ADSB: add sanity check for access to msg.raw buffer#32654
Merged
Conversation
similarly to the code in GDL90_RX_IN_PACKET, we should check if there is space in this buffer before actually writing data into it.
tridge
approved these changes
Apr 15, 2026
github-project-automation
Bot
moved this from ReadyForDevCall
to Done
in Peter's ArduPilot 4.8 Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
similarly to the code in GDL90_RX_IN_PACKET, we should check if there is space in this buffer before actually writing data into it.
Testing (more checks increases chance of being merged)
Description
This appears to fix an arbitrary-length buffer-overwrite problem; a sequence that only contains escape-byte/normal-byte/escape-byte/normal-byte repeatedly will just continue to overwrite past the buffer.
This issue was responsibly disclosed to the ArduPilot development team by secmate.dev. Many thanks to them for supplying a candidate patch - I have applied their fix here in only a slightly different manner.