Skip to content

AP_ADSB: avoid buffer overwrite in AP_ADSB_Sagetech_MXS #32656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tridge merged 1 commit into from
Apr 15, 2026
+6 −0
Merged

AP_ADSB: avoid buffer overwrite in AP_ADSB_Sagetech_MXS #32656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions libraries/AP_ADSB/AP_ADSB_Sagetech_MXS.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,12 @@ bool AP_ADSB_Sagetech_MXS::parse_byte(const uint8_t data)
case ParseState::WaitingFor_PayloadLen:
message_in.checksum += data;
message_in.packet.payload_length = data;
// the checksum is also appended to the payload array, so
// we only allow a 254 byte payload here:
if (message_in.packet.payload_length >= ARRAY_SIZE(message_in.packet.payload)) {
message_in.state = ParseState::WaitingFor_Start;
break;
}
message_in.index = 0;
message_in.state = (data == 0) ? ParseState::WaitingFor_Checksum : ParseState::WaitingFor_PayloadContents;
break;
Expand Down
Loading