hwdef: Add JFB200 of JAE flight controllers

[n-ito2222]

Summary

Add hwdef JFB200 for a JAE new flight controller.

Classification & Testing (check all that apply and add your own)

• Checked by a human programmer
• Non-functional change
• No-binary change
• Infrastructure change (e.g. unit tests, helper scripts)
• Automated test(s) verify changes (e.g. unit test, autotest)
• Tested manually, description below (e.g. SITL)
• Tested on hardware
• Logs attached
• Logs available on request

[peterbarker]

libraries/AP_HAL_ChibiOS/hwdef/JFB200/README.md:50 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- PWM  1,  2,  3 and  4 in gro..."]
libraries/AP_HAL_ChibiOS/hwdef/JFB200/README.md:77 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- PWM(9)  50"]
libraries/AP_HAL_ChibiOS/hwdef/JFB200/README.md:91 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- ADC Pin0  -> not used"]
libraries/AP_HAL_ChibiOS/hwdef/JFB200/README.md:116 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- the internal I2C port  is bu..."]
libraries/AP_HAL_ChibiOS/hwdef/JFB200/README.md:128 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- ARMED status signal output"]

[rmackay9]

Hi @n-ito2222,

I suspect you're working on the PR and it's not quite done yet but I just want to point out that we don't accept merge commits so it would be good to rebase this on master to remove the one that has appeared.

[n-ito2222]

HI @rmackay9,

Hi @n-ito2222,

I suspect you're working on the PR and it's not quite done yet but I just want to point out that we don't accept merge commits so it would be good to rebase this on master to remove the one that has appeared.

I'm sorry.
I made a mistake in the operation.

[n-ito2222]

Hi @rmackay9, @peterbarker ,
I've made revisions based on the review comments, and updated this PR.

Thank you for your cooperation.

[andyp1per]

don't think this does anything - remove

[n-ito2222]

Hi @andyp1per,

Excuse me.
If I remove define CORE-CM7, the build fails.
Are there any other settings I need to configure?

[andyp1per]

VERYLOW?

[rmackay9]

@andyp1per, thank you very much for the review!

[Hwurzburg]

• I need images before I can review....see wiki for README requirements https://ardupilot.org/dev/docs/readme_file.html#readme-file
• everything in the defaults.param file should be removed...rssi params should not be set...user should set..IMU mask is default,,,,serial protocols in hwdef..that bd voltage min is too low...everything should be able to take 4.75V as a min in a proper design
• commit structure incorrect

[n-ito2222]

Hi @Hwurzburg,

Thanks.

• I need images before I can review....see wiki for README requirements https://ardupilot.org/dev/docs/readme_file.html#readme-file
• everything in the defaults.param file should be removed...rssi params should not be set...user should set..IMU mask is default,,,,serial protocols in hwdef..that bd voltage min is too low...everything should be able to take 4.75V as a min in a proper design
• commit structure incorrect

I will modify Readme.md and delete defaults.param.

I'm sorry.
I don't understand "commit structure incorrect". Could you please point out where the wrong are?

[rmackay9]

Hi @n-ito2222,

Re the "commit structure" issue, I think the problem is that the bootloaders should be in a separate commit and that commit title should be prefixed with "Tools:". So it should be something like, "Tools: add JFB200 bootloaders"

[n-ito2222]

HI @rmackay9,

Thanks.

Hi @n-ito2222,

Re the "commit structure" issue, I think the problem is that the bootloaders should be in a separate commit and that commit title should be prefixed with "Tools:". So it should be something like, "Tools: add JFB200 bootloaders"

I understand.
I will create a new pull request for binary of bootloader after this pull request is closed.

[n-ito2222]

Hi @Hwurzburg,

Hi @Hwurzburg,

Thanks.

• I need images before I can review....see wiki for README requirements https://ardupilot.org/dev/docs/readme_file.html#readme-file
• everything in the defaults.param file should be removed...rssi params should not be set...user should set..IMU mask is default,,,,serial protocols in hwdef..that bd voltage min is too low...everything should be able to take 4.75V as a min in a proper design
• commit structure incorrect

I will modify Readme.md and delete defaults.param.

I'm sorry. I don't understand "commit structure incorrect". Could you please point out where the wrong are?

I'm sorry, I commented that I would delete defaults.param, but I would like to keep "BRD_VBUS_MIN 4.75".
I would like that our JFB200 board need 4.75V minimum.

Thank you for your cooperation.

[rmackay9]

Hi @n-ito2222,

Re the bootloaders, no need to put them into a separate PR. They just need to be in separate commits within this PR. In fact, we won't merge this unless those bootloader changes are split into a separate commit. If you're not sure how to do that using git I could do it for you.

[n-ito2222]

Hi @rmackay9,

Thanks.
I understand. I will separate the commit for the bootloader binary.

[rmackay9]

Hi @n-ito2222,

You've probably seen them but there seem to be some formatting issues.

libraries/AP_HAL_ChibiOS/hwdef/JFB200/README.md:8 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Features"]
libraries/AP_HAL_ChibiOS/hwdef/JFB200/README.md:9 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Processor"]
libraries/AP_HAL_ChibiOS/hwdef/JFB200/README.md:32 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## UART Mapping"]
libraries/AP_HAL_ChibiOS/hwdef/JFB200/README.md:33 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- SERIAL0 -> USB"]
libraries/AP_HAL_ChibiOS/hwdef/JFB200/README.md:57 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- PWM 1, 2, 3 and 4 in gro..."]
libraries/AP_HAL_ChibiOS/hwdef/JFB200/README.md:81 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- PWM(9) 50"]
libraries/AP_HAL_ChibiOS/hwdef/JFB200/README.md:178 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "### ADC/IO port"]
libraries/AP_HAL_ChibiOS/hwdef/JFB200/README.md:272 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "### RCIN port"]
libraries/AP_HAL_ChibiOS/hwdef/JFB200/README.md:281 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "### S.OUT port"]
libraries/AP_HAL_ChibiOS/hwdef/JFB200/README.md:290 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "### POWER1, POWER2 ports"]

images and README added

[rmackay9]

@Hwurzburg, the README has been added with images

@andyp1per no pressure but if you get a chance to re-review that would be great, txs!

[Hwurzburg]

Preliminary review....cant fully review until next week due to home move:
-which UARTs have DMA should be noted
-PWM outputs noted as bi-dir buffered...you mean have BDShot capability...if so, this wording should be used in readme

• CAN ports should be enabled in defaults.parm
• why are PWM 1-8 being prevented from being used as GPIOs??
• pinouts for UARTs should have the UART number included in the RX/TX pin names in the pinout lists (not serial port number...that translation is shown in the UART table section)
• UART table can show connector name, BUT the default protocol should be shown also....ie TELEM1 is MAVLink2 (unless its obvious, like GPS)