Skip to content

feat(lobby): added a new player component parameter to notifysessionstart command to streamline processes#892

Merged
winton-library merged 3 commits into
mainfrom
winton/notify-session-start-playercomp
Apr 29, 2026
Merged

feat(lobby): added a new player component parameter to notifysessionstart command to streamline processes#892
winton-library merged 3 commits into
mainfrom
winton/notify-session-start-playercomp

Conversation

@winton-library
Copy link
Copy Markdown
Contributor

@winton-library winton-library commented Apr 28, 2026

TL;DR

Include player data in the session start notification sent to the game shard.

What changed?

NotifySessionStartCommand now includes a Players field containing the list of PlayerComponent entries associated with the lobby. The dispatchSessionStart function was updated to accept a lobbyIndex parameter, which is used to gather the lobby's players via gatherLobbyPlayers before sending the command.

How to test?

Start a lobby session and verify that the game shard receives a NotifySessionStartCommand with a populated Players field that correctly reflects the players in the lobby at the time the session starts.

Why make this change?

The game shard previously had no information about which players were part of a session when it started. By including the player list in the session start notification, the game shard can immediately act on player data without needing to query back to the lobby world.

Copy link
Copy Markdown
Contributor Author


How to use the Graphite Merge Queue

Add the label graphite/merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@winton-library winton-library marked this pull request as ready for review April 28, 2026 17:52
@winton-library winton-library added the enhancement New feature or request label Apr 29, 2026 — with Graphite App
@winton-library winton-library self-assigned this Apr 29, 2026
@winton-library winton-library merged commit 433d9b2 into main Apr 29, 2026
8 checks passed
@winton-library winton-library deleted the winton/notify-session-start-playercomp branch April 29, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants