Skip to content
This repository was archived by the owner on Jun 19, 2026. It is now read-only.

Commit b0931c9

Browse files
chore: Fix trusted-scripts path (#7)
* chore: test * chore: fix trusted-scripts path
1 parent 9dcb7d5 commit b0931c9

3 files changed

Lines changed: 40 additions & 17 deletions

File tree

.github/workflows/benchmark-dashboard.yml

Lines changed: 26 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,17 @@ jobs:
5353
ARTIFACT_NAME="benchmark-${{ inputs.provider }}-${{ inputs.model }}-$(date +%Y%m%d-%H%M%S)"
5454
mv tests/results "tests/${ARTIFACT_NAME}"
5555
fi
56+
# Create docs/benchmarks if it doesn't exist for publish_benchmarks.py
57+
mkdir -p docs/benchmarks
58+
59+
- name: Generate dashboard
60+
working-directory: workspace
61+
run: |
62+
uv run --project tests python3 ci/publish_benchmarks.py \
63+
--provider ${{ inputs.provider }} \
64+
--model ${{ inputs.model }} \
65+
--branch benchmark-history \
66+
--no-benchmark
5667
5768
- name: Generate dashboard
5869
working-directory: workspace
@@ -79,11 +90,19 @@ jobs:
7990
ref: benchmark-history
8091
path: benchmark-data
8192

82-
- name: Verify deployment
93+
- name: Copy results to docs
94+
run: |
95+
mkdir -p workspace/docs/benchmarks
96+
cp benchmark-data/docs/benchmarks.json workspace/docs/benchmarks.json 2>/dev/null || true
97+
cp benchmark-data/docs/index.html workspace/docs/index.html 2>/dev/null || true
98+
# Also copy individual benchmark results if they exist
99+
cp -r benchmark-data/docs/benchmarks/*.json workspace/docs/benchmarks/ 2>/dev/null || true
100+
101+
- name: Commit and push updates
102+
working-directory: workspace
83103
run: |
84-
echo "Benchmark data directory contents:"
85-
ls -la benchmark-data/docs/
86-
echo ""
87-
echo "GitHub Pages will be served from benchmark-history branch"
88-
echo "Dashboard will be available at:"
89-
echo "https://${{ github.repository }}/index.html"
104+
git config user.name "GitHub Actions"
105+
git config user.email "actions@github.com"
106+
git add docs/
107+
git commit -m "Update benchmark data" || echo "No changes to commit"
108+
git push origin HEAD:benchmark-history

.github/workflows/skill-validation.yml

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,10 @@ jobs:
7171
ref: main
7272
path: trusted-scripts
7373

74-
# Checkout actual PR code to test
74+
# Checkout actual PR code to test (to different path to avoid overwriting trusted-scripts)
7575
- uses: actions/checkout@v4
76+
with:
77+
path: pr-code
7678

7779
- uses: actions/setup-node@v4
7880
if: matrix.provider == 'copilot'
@@ -100,10 +102,11 @@ jobs:
100102
COPILOT_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
101103
OLLAMA_API_KEY: ${{ secrets.OLLAMA_API_KEY }}
102104
TRULENS_OTEL_ENDPOINT: ${{ secrets.TRULENS_OTEL_ENDPOINT }}
105+
working-directory: pr-code
103106
run: |
104107
# Construct arguments array for safety
105108
ARGS=(--provider "${{ matrix.provider }}" --model "${{ matrix.model }}" --judge --verbose --report --threshold 50)
106-
109+
107110
if [ -n "${{ matrix.extra_args }}" ]; then
108111
# Split extra_args safely if needed, but for now assuming simple flags
109112
ARGS+=(${{ matrix.extra_args }})
@@ -116,15 +119,16 @@ jobs:
116119
fi
117120
118121
echo "Running evaluation..."
119-
# Use trusted script with correct project path
120-
uv run --project . --frozen trusted-scripts/tests/evaluator.py "${ARGS[@]}"
122+
# Run evaluator from trusted-scripts/tests
123+
# The working-directory is pr-code, so evaluator.py finds PR code at current directory
124+
uv run --project . --frozen ../trusted-scripts/tests/evaluator.py "${ARGS[@]}"
121125
122126
- name: Upload results
123127
if: always()
124128
uses: actions/upload-artifact@v4
125129
with:
126130
name: ${{ steps.artifact.outputs.name }}
127-
path: tests/results/
131+
path: pr-code/tests/results/
128132
retention-days: 1
129133

130134
consolidate:
@@ -141,14 +145,14 @@ jobs:
141145

142146
- uses: actions/download-artifact@v4
143147
with:
144-
path: tests/results/
148+
path: pr-code/tests/results/
145149

146150
- name: Consolidate results
147-
run: python3 trusted-scripts/ci/consolidate_results.py
151+
run: python3 trusted-scripts/ci/consolidate_results.py --results-dir pr-code/tests/results --output-file pr-code/comment.md
148152

149153
- name: Post to PR
150154
uses: marocchino/sticky-pull-request-comment@v2
151-
if: hashFiles('comment.md') != ''
155+
if: hashFiles('pr-code/comment.md') != ''
152156
with:
153157
number: ${{ github.event.issue.number }}
154-
path: comment.md
158+
path: pr-code/comment.md

skills/ps-error-handling-design/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: Design systems with explicit error handling. Avoid throwing excepti
44
severity: WARN
55
---
66

7-
## Principle
7+
# Principle
88

99
Treat error handling as a first-class design concern, not an afterthought:
1010

0 commit comments

Comments
 (0)