Skip to content

Commit 516912c

Browse files
authored
chore: downgrade bitcoinj-core to 0.14.7 (#51)
1 parent c6ae3c9 commit 516912c

3 files changed

Lines changed: 4 additions & 18 deletions

File tree

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ if (project.hasProperty("signing.keyId")) {
9494
}
9595

9696
dependencies {
97-
compile group: 'org.bitcoinj', name: 'bitcoinj-core', version: '0.15.2'
97+
compile group: 'org.bitcoinj', name: 'bitcoinj-core', version: '0.14.7'
9898
compile group: 'org.bouncycastle', name: 'bcprov-jdk15on', version: '1.62'
9999
compile group: 'com.google.code.gson', name: 'gson', version: '2.8.0'
100100
compile 'com.google.guava:guava:28.0-jre'

src/main/java/org/arkecosystem/crypto/transactions/Transaction.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import org.arkecosystem.crypto.identities.PrivateKey;
88
import org.bitcoinj.core.ECKey;
99
import org.bitcoinj.core.Sha256Hash;
10-
import org.bitcoinj.core.SignatureDecodeException;
1110

1211
import java.lang.reflect.Type;
1312
import java.nio.ByteBuffer;
@@ -67,11 +66,7 @@ public boolean verify() {
6766
byte[] signature = Hex.decode(this.signature);
6867
byte[] bytes = toBytes();
6968

70-
try {
71-
return ECKey.verify(Sha256Hash.hash(bytes), signature, keys.getPubKey());
72-
} catch (SignatureDecodeException e) {
73-
return false;
74-
}
69+
return ECKey.verify(Sha256Hash.hash(bytes), signature, keys.getPubKey());
7570
}
7671

7772
public boolean secondVerify(String secondPublicKey) {
@@ -80,11 +75,7 @@ public boolean secondVerify(String secondPublicKey) {
8075
byte[] signature = Hex.decode(this.signSignature);
8176
byte[] bytes = toBytes(false);
8277

83-
try {
84-
return ECKey.verify(Sha256Hash.hash(bytes), signature, keys.getPubKey());
85-
} catch (SignatureDecodeException e) {
86-
return false;
87-
}
78+
return ECKey.verify(Sha256Hash.hash(bytes), signature, keys.getPubKey());
8879
}
8980

9081
public Transaction parseSignatures(String serialized, int startOffset) {

src/main/java/org/arkecosystem/crypto/utils/Message.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import org.arkecosystem.crypto.identities.PrivateKey;
66
import org.bitcoinj.core.ECKey;
77
import org.bitcoinj.core.Sha256Hash;
8-
import org.bitcoinj.core.SignatureDecodeException;
98

109
import java.util.HashMap;
1110
import java.util.Map;
@@ -35,11 +34,7 @@ public boolean verify() {
3534
byte[] signature = Hex.decode(this.signature);
3635
byte[] messageBytes = Sha256Hash.hash(this.message.getBytes());
3736

38-
try {
39-
return ECKey.verify(messageBytes, signature, keys.getPubKey());
40-
} catch (SignatureDecodeException e) {
41-
return false;
42-
}
37+
return ECKey.verify(messageBytes, signature, keys.getPubKey());
4338
}
4439

4540
public Map toMap() {

0 commit comments

Comments
 (0)