fix: handle SignatureDecodeException (#85)

* fix: handle SignatureDecodeException

* fix: exception handling in Message.java re: update bitcoinj

* fix: remove bouncy castle from deps // collision with bitcoinj

* chore: update guava package

Author: Kristjan Kosic

build.gradle

@@ -74,6 +74,12 @@ uploadArchives {
                         organization = 'Ark Ecosystem'
                         organizationUrl = 'https://ark.io'
                     }
+                    developer {
+                        name = 'Kristjan Kosic'
+                        email = 'kristjan@ark.io'
+                        organization = 'Ark Ecosystem'
+                        organizationUrl = 'https://ark.io'
+                    }
                 }
 
                 scm {
@@ -95,12 +101,11 @@ if (project.hasProperty("signing.keyId")) {
 
 dependencies {
     compile group: 'org.bitcoinj', name: 'bitcoinj-core', version: '0.15.6'
-    compile group: 'org.bouncycastle', name: 'bcprov-jdk15on', version: '1.64'
     compile group: 'com.google.code.gson', name: 'gson', version: '2.8.6'
-    compile 'com.google.guava:guava:28.0-jre'
+    compile 'com.google.guava:guava:28.2-jre'
 
-    testImplementation 'org.junit.jupiter:junit-jupiter-api:5.5.0'
-    testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.5.0'
+    testImplementation 'org.junit.jupiter:junit-jupiter-api:5.5.2'
+    testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.5.2'
 }
 
 test {

src/main/java/org/arkecosystem/crypto/transactions/Transaction.java

@@ -7,6 +7,7 @@
 import org.arkecosystem.crypto.identities.PrivateKey;
 import org.bitcoinj.core.ECKey;
 import org.bitcoinj.core.Sha256Hash;
+import org.bitcoinj.core.SignatureDecodeException;
 
 import java.lang.reflect.Type;
 import java.nio.ByteBuffer;
@@ -66,7 +67,11 @@ public boolean verify() {
         byte[] signature = Hex.decode(this.signature);
         byte[] bytes = toBytes();
 
-        return ECKey.verify(Sha256Hash.hash(bytes), signature, keys.getPubKey());
+        try {
+            return ECKey.verify(Sha256Hash.hash(bytes), signature, keys.getPubKey());
+        } catch (SignatureDecodeException e) {
+            return false;
+        }
     }
 
     public boolean secondVerify(String secondPublicKey) {
@@ -75,7 +80,11 @@ public boolean secondVerify(String secondPublicKey) {
         byte[] signature = Hex.decode(this.signSignature);
         byte[] bytes = toBytes(false);
 
-        return ECKey.verify(Sha256Hash.hash(bytes), signature, keys.getPubKey());
+        try {
+            return ECKey.verify(Sha256Hash.hash(bytes), signature, keys.getPubKey());
+        } catch (SignatureDecodeException e) {
+            return false;
+        }
     }
 
     public Transaction parseSignatures(String serialized, int startOffset) {

src/main/java/org/arkecosystem/crypto/utils/Message.java

@@ -5,6 +5,7 @@
 import org.arkecosystem.crypto.identities.PrivateKey;
 import org.bitcoinj.core.ECKey;
 import org.bitcoinj.core.Sha256Hash;
+import org.bitcoinj.core.SignatureDecodeException;
 
 import java.util.HashMap;
 import java.util.Map;
@@ -34,7 +35,11 @@ public boolean verify() {
         byte[] signature = Hex.decode(this.signature);
         byte[] messageBytes = Sha256Hash.hash(this.message.getBytes());
 
-        return ECKey.verify(messageBytes, signature, keys.getPubKey());
+        try {
+            return ECKey.verify(messageBytes, signature, keys.getPubKey());
+        } catch (SignatureDecodeException e) {
+            return false;
+        }
     }
 
     public Map toMap() {