refactor(api-http): remove senderId from schema (#1262)

* remove senderId from schema

* empty commit

Author: oXtxNt9U

packages/api-database/source/search/filters/transaction-filter.ts

@@ -25,13 +25,7 @@ export class TransactionFilter {
 				case "address": {
 					return handleOrCriteria(criteria.address, async (c) =>
 						// @ts-ignore
-						this.handleAddressCriteria(c, walletRepository),
-					);
-				}
-				case "senderId": {
-					return handleOrCriteria(criteria.senderId, async (c) =>
-						// @ts-ignore
-						this.handleSenderIdCriteria(c, walletRepository),
+						this.handleAddressCriteria(c),
 					);
 				}
 				case "to": {
@@ -118,30 +112,13 @@ export class TransactionFilter {
 		walletRepository: WalletRepository,
 	): Promise<Expression<Transaction>> {
 		const expressions: Expression<Transaction>[] = await Promise.all([
-			this.handleSenderIdCriteria(criteria, walletRepository),
+			this.handleSenderAddressCritera(criteria),
 			this.handleRecipientAddressCriteria(criteria),
 		]);
 
 		return { expressions, op: "or" };
 	}
 
-	private static async handleSenderIdCriteria(
-		criteria: EqualCriteria<string>,
-		walletRepository: WalletRepository,
-	): Promise<Expression<Transaction>> {
-		const wallet = await walletRepository
-			.createQueryBuilder()
-			.select("public_key")
-			.where("address = :address", { address: criteria })
-			.getRawOne<{ public_key: string }>();
-
-		if (!wallet || !wallet.public_key) {
-			return { op: "false" };
-		}
-
-		return this.handleSenderPublicKeyCriteria(wallet.public_key);
-	}
-
 	private static async handleSenderPublicKeyCriteria(
 		criteria: EqualCriteria<string>,
 	): Promise<Expression<Transaction>> {

packages/api-database/source/search/types/criteria.ts

@@ -37,7 +37,6 @@ export type BlockDataWithTransactionData = {
 
 export type TransactionCriteria = {
 	address?: OrEqualCriteria<string>;
-	senderId?: OrEqualCriteria<string>;
 	to?: OrEqualCriteria<string>;
 	hash?: OrEqualCriteria<string>;
 	version?: OrEqualCriteria<number>;

packages/api-http/integration/routes/transactions.test.ts

@@ -81,10 +81,6 @@ describe<{
 				path: `/transactions?from=${transaction.from}`,
 				result: [...transactionsResponse].filter((tx) => tx.from === transaction.from),
 			},
-			{
-				path: `/transactions?senderId=${transaction.from}`,
-				result: [...transactionsResponse].filter((tx) => tx.from === transaction.from),
-			},
 			{
 				path: `/transactions?address=${transaction.to}`,
 				result: [...transactionsResponse].filter((tx) => tx.to === transaction.to),

packages/api-http/source/schemas/schemas.ts

@@ -72,7 +72,6 @@ export const transactionCriteriaSchemas = {
 	gasPrice: Schemas.orNumericCriteria(Joi.number().integer().min(0)),
 	hash: Schemas.orEqualCriteria(Joi.string().hex().length(64)),
 	nonce: Schemas.orNumericCriteria(Joi.number().integer().positive()),
-	senderId: Schemas.orEqualCriteria(address),
 	senderPublicKey: Schemas.orEqualCriteria(Joi.string().hex().length(66)),
 	timestamp: Schemas.orNumericCriteria(Joi.number().integer().min(0)),
 	to: Schemas.orEqualCriteria(address),