refactor: remove maxTransactions milestone (#984)

* Remove maxTransactions in verifier

* Ignore in get transactions

* Remove injected configuration

* Remove from milestones and tests

* Remove from crypto.json

Author: sebastijankuzner

packages/api-http/test/fixtures/node_configuration.json

@@ -3,8 +3,7 @@
 		"block": {
 			"version": 1,
 			"maxPayload": 2097152,
-			"maxGasLimit": 10000000,
-			"maxTransactions": 150
+			"maxGasLimit": 10000000
 		},
 		"epoch": "2024-05-31T00:00:00.000Z",
 		"evmSpec": "Shanghai",

packages/configuration-generator/source/generators/genesis-block.test.ts

@@ -33,7 +33,7 @@ describe<{
 			milestones: [
 				{
 					address: { bech32m: "ark" },
-					block: { maxGasLimit: 30_000_000, maxPayload: 2_097_152, maxTransactions: 150, version: 1 },
+					block: { maxGasLimit: 30_000_000, maxPayload: 2_097_152, version: 1 },
 					blockTime: 8000,
 					evmSpec: Contracts.Evm.SpecId.SHANGHAI,
 					// @ts-ignore

packages/configuration-generator/source/generators/milestones.test.ts

@@ -37,7 +37,6 @@ describe<{
 					block: {
 						maxGasLimit: 1000,
 						maxPayload: 2000,
-						maxTransactions: 100,
 						version: 1,
 					},
 					epoch: date.toISOString().slice(0, 11) + "00:00:00.000Z",

packages/configuration-generator/source/generators/milestones.ts

@@ -11,7 +11,6 @@ export class MilestonesGenerator {
 				block: {
 					maxGasLimit: options.maxBlockGasLimit,
 					maxPayload: options.maxBlockPayload,
-					maxTransactions: options.maxTxPerBlock,
 					version: 1,
 				},
 				epoch: options.epoch.toISOString().slice(0, 11) + "00:00:00.000Z",

packages/contracts/source/contracts/crypto/networks.ts

@@ -30,7 +30,6 @@ export type Network = {
 export type MilestoneBlock = {
 	maxPayload: number;
 	maxGasLimit: number;
-	maxTransactions: number;
 	version: number;
 };
 export type MilestoneSatoshi = {

packages/core/bin/config/devnet/core/crypto.json

@@ -2576,7 +2576,6 @@
 			"block": {
 				"maxGasLimit": 10000000,
 				"maxPayload": 2097152,
-				"maxTransactions": 150,
 				"version": 1
 			},
 			"epoch": "2025-06-11T00:00:00.000Z",

packages/crypto-config/source/configuration.test.ts

@@ -35,7 +35,7 @@ describe<{
 		assert.equal(configManager.getMilestones(), [
 			{
 				roundValidators: 0,
-				block: { maxPayload: 2_097_152, maxGasLimit: 10_000_000, maxTransactions: 150, version: 1 },
+				block: { maxPayload: 2_097_152, maxGasLimit: 10_000_000, version: 1 },
 				gas: cryptoJson.milestones[0].gas,
 				epoch: cryptoJson.milestones[0].epoch,
 				evmSpec: cryptoJson.milestones[0].evmSpec,
@@ -53,7 +53,7 @@ describe<{
 			},
 			{
 				roundValidators: 53,
-				block: { maxPayload: 2_097_152, maxGasLimit: 10_000_000, maxTransactions: 150, version: 1 },
+				block: { maxPayload: 2_097_152, maxGasLimit: 10_000_000, version: 1 },
 				gas: cryptoJson.milestones[0].gas,
 				epoch: cryptoJson.milestones[0].epoch,
 				evmSpec: cryptoJson.milestones[0].evmSpec,
@@ -71,7 +71,7 @@ describe<{
 			},
 			{
 				roundValidators: 53,
-				block: { maxPayload: 2_097_152, maxGasLimit: 10_000_000, maxTransactions: 150, version: 1 },
+				block: { maxPayload: 2_097_152, maxGasLimit: 10_000_000, version: 1 },
 				gas: cryptoJson.milestones[0].gas,
 				epoch: cryptoJson.milestones[0].epoch,
 				evmSpec: cryptoJson.milestones[0].evmSpec,

packages/kernel/test/stubs/config-with-crypto/crypto.json

@@ -1824,7 +1824,6 @@
 			},
 			"block": {
 				"maxPayload": 2097152,
-				"maxTransactions": 150,
 				"version": 1
 			},
 			"blockTime": 8000,
@@ -1844,7 +1843,6 @@
 			},
 			"block": {
 				"maxPayload": 2097152,
-				"maxTransactions": 150,
 				"version": 1
 			},
 			"blockTime": 8000,

packages/processor/source/verifiers/transaction-length-verifier.ts

@@ -6,24 +6,11 @@ export class TransactionLengthVerifier implements Contracts.Processor.Handler {
 	@inject(Identifiers.Application.Instance)
 	protected readonly app!: Contracts.Kernel.Application;
 
-	@inject(Identifiers.Cryptography.Configuration)
-	private readonly configuration!: Contracts.Crypto.Configuration;
-
 	public async execute(unit: Contracts.Processor.ProcessableUnit): Promise<void> {
 		const block = unit.getBlock();
 
 		if (block.transactions.length !== block.data.transactionsCount) {
 			throw new Exceptions.InvalidTransactionsLength(block);
 		}
-
-		if (block.data.number === this.configuration.getGenesisHeight()) {
-			return;
-		}
-
-		const maxTransactions = this.configuration.getMilestone().block.maxTransactions;
-
-		if (block.data.transactionsCount > maxTransactions) {
-			throw new Exceptions.MaxTransactionsExceeded(block);
-		}
 	}
 }

packages/transaction-pool-worker/source/handlers/get-transactions.ts

@@ -18,10 +18,6 @@ export class GetTransactionsHandler {
 
 		const candidateTransactions: Contracts.Crypto.Transaction[] = [];
 		for (const transaction of await this.poolQuery.getFromHighestPriority().all()) {
-			if (candidateTransactions.length === milestone.block.maxTransactions) {
-				break;
-			}
-
 			if (bytesLeft - 4 - transaction.serialized.length < 0) {
 				break;
 			}