feat(crypto-config): add schema (#1257)

* Schema

* Install ajv

* Remove slip44

* Extract build milestones

* Remove double milestones

* Verify schemas

* Move schemas to validation package

* Fix tests

* Remove schemas from crypto-validation

* Temporarily disable schemas

* Fix crypto-key-pair-ecdsa

* Fix crypto-key-pair-bls12-381 tests

* Fix crypto-address-base58 tests

* Fix crypto-address-keccak256 tests

* Test crypto-signature-bls12-381

* Fix crypto-transaction

* Fix crypto-block

* Fix crypto-messages

* Fix crypto-commit

* FIx crypto-proposal

* Fix configuration-generator

* Tmp

* Test api-evm

* Fix p2p

* Fix core

* style: resolve style guide violations [ci-lint-fix]

* Remove unused deps

* Fix unit tests

* Inject validation

* Verify shema

* Support verification skip

* Fix tests

* style: resolve style guide violations [ci-lint-fix]

Author: sebastijankuzner

packages/api-development/source/controllers/node.ts

@@ -37,7 +37,6 @@ export class NodeController extends Controller {
 				},
 				explorer: network.client.explorer,
 				nethash: network.nethash,
-				slip44: network.slip44,
 				symbol: network.client.symbol,
 				token: network.client.token,
 				version: network.pubKeyHash,

packages/api-evm/package.json

@@ -38,7 +38,6 @@
 		"@mainsail/contracts": "workspace:*",
 		"@mainsail/crypto-address-keccak256": "workspace:*",
 		"@mainsail/crypto-block": "workspace:*",
-		"@mainsail/crypto-validation": "workspace:*",
 		"@mainsail/test-runner": "workspace:*",
 		"@mainsail/validation": "workspace:*",
 		"@types/semver": "7.7.0",

packages/api-evm/source/actions/eth-get-balance.test.ts

@@ -1,16 +1,16 @@
 import { Identifiers } from "@mainsail/constants";
 import { schemas as keccak256Schemas } from "@mainsail/crypto-address-keccak256";
-import { schemas as validationSchemas } from "@mainsail/crypto-validation";
-import { Validator } from "@mainsail/validation";
+import { ServiceProvider as ValidationServiceProvider } from "@mainsail/validation";
 import { Application } from "@mainsail/kernel";
 import { describe } from "@mainsail/test-runner";
+import { Contracts } from "@mainsail/contracts";
 import { schemas } from "../validation/index.js";
 import { EthGetBalanceAction } from "./index.js";
 
 describe<{
 	app: Application;
 	action: EthGetBalanceAction;
-	validator: Validator;
+	validator: Contracts.Crypto.Validator;
 	evm: any;
 }>("EthGetBalanceAction", ({ beforeEach, it, assert }) => {
 	let balance = BigInt(0);
@@ -25,10 +25,12 @@ describe<{
 		};
 
 		context.app = new Application();
+		await context.app.resolve(ValidationServiceProvider).register();
+
 		context.app.bind(Identifiers.Evm.Instance).toConstantValue(context.evm);
 
 		context.action = context.app.resolve(EthGetBalanceAction);
-		context.validator = context.app.resolve(Validator);
+		context.validator = context.app.get<Contracts.Crypto.Validator>(Identifiers.Cryptography.Validator);
 	});
 
 	it("should have a name", ({ action }) => {
@@ -37,7 +39,6 @@ describe<{
 
 	it("schema should be array with 0 parameters", ({ action, validator }) => {
 		validator.addSchema(keccak256Schemas.address);
-		validator.addSchema(validationSchemas.prefixedQuantityHex);
 		validator.addSchema(schemas.blockTag);
 		validator.addSchema(action.schema);
 

packages/api-evm/source/actions/eth-get-block-transaction-count-by-hash.test.ts

@@ -1,15 +1,15 @@
 import { Identifiers } from "@mainsail/constants";
 import { schemas as cryptoBlockSchemas } from "@mainsail/crypto-block";
-import { schemas as cryptoValidationSchemas } from "@mainsail/crypto-validation";
-import { Validator } from "@mainsail/validation";
+import { ServiceProvider as ValidationServiceProvider } from "@mainsail/validation";
 import { Application } from "@mainsail/kernel";
 import { describe } from "@mainsail/test-runner";
+import { Contracts } from "@mainsail/contracts";
 import { EthGetBlockTransactionCountByHash } from "./index.js";
 
 describe<{
 	app: Application;
 	action: EthGetBlockTransactionCountByHash;
-	validator: Validator;
+	validator: Contracts.Crypto.Validator;
 	database: any;
 }>("EthGetBlockTransactionCountByHash", ({ beforeEach, it, assert, stub }) => {
 	beforeEach(async (context) => {
@@ -18,18 +18,18 @@ describe<{
 		};
 
 		context.app = new Application();
+		await context.app.resolve(ValidationServiceProvider).register();
 		context.app.bind(Identifiers.Database.Service).toConstantValue(context.database);
 
 		context.action = context.app.resolve(EthGetBlockTransactionCountByHash);
-		context.validator = context.app.resolve(Validator);
+		context.validator = context.app.get<Contracts.Crypto.Validator>(Identifiers.Cryptography.Validator);
 	});
 
 	it("should have a name", ({ action }) => {
 		assert.equal(action.name, "eth_getBlockTransactionCountByHash");
 	});
 
 	it("schema should be array with 0 parameters", ({ action, validator }) => {
-		validator.addSchema(cryptoValidationSchemas.prefixedQuantityHex);
 		validator.addSchema(cryptoBlockSchemas.prefixedBlockHash);
 		validator.addSchema(action.schema);
 

packages/api-evm/source/actions/eth-get-block-transaction-count-by-number.test.ts

@@ -1,34 +1,36 @@
 import { Identifiers } from "@mainsail/constants";
-import { Validator } from "@mainsail/validation";
-import { schemas as cryptoValidationSchemas } from "@mainsail/crypto-validation";
+import { ServiceProvider as ValidationServiceProvider } from "@mainsail/validation";
 import { Application } from "@mainsail/kernel";
 import { describe } from "@mainsail/test-runner";
+import { Contracts } from "@mainsail/contracts";
 import { EthGetBlockTransactionCountByNumber } from "./index.js";
 
 describe<{
 	app: Application;
 	action: EthGetBlockTransactionCountByNumber;
-	validator: Validator;
+	validator: Contracts.Crypto.Validator;
 	database: any;
-}>("EthGetBlockTransactionCountByHash", ({ beforeEach, it, assert, stub }) => {
+}>("EthGetBlockTransactionCountByNumber", ({ beforeEach, it, assert, stub }) => {
 	beforeEach(async (context) => {
 		context.database = {
 			getBlockHeader: async () => undefined,
 		};
 
 		context.app = new Application();
+
+		context.app.resolve(ValidationServiceProvider).register();
+
 		context.app.bind(Identifiers.Database.Service).toConstantValue(context.database);
 
 		context.action = context.app.resolve(EthGetBlockTransactionCountByNumber);
-		context.validator = context.app.resolve(Validator);
+		context.validator = context.app.get<Contracts.Crypto.Validator>(Identifiers.Cryptography.Validator);
 	});
 
 	it("should have a name", ({ action }) => {
 		assert.equal(action.name, "eth_getBlockTransactionCountByNumber");
 	});
 
 	it("schema should be array with 0 parameters", ({ action, validator }) => {
-		validator.addSchema(cryptoValidationSchemas.prefixedQuantityHex);
 		validator.addSchema(action.schema);
 
 		assert.undefined(validator.validate("jsonRpc_eth_getBlockTransactionCountByNumber", ["0x0"]).errors);

packages/api-evm/source/actions/eth-get-code.test.ts

@@ -1,16 +1,16 @@
 import { Identifiers } from "@mainsail/constants";
 import { schemas as keccak256Schemas } from "@mainsail/crypto-address-keccak256";
-import { schemas as validationSchemas } from "@mainsail/crypto-validation";
-import { Validator } from "@mainsail/validation";
+import { ServiceProvider as ValidationServiceProvider } from "@mainsail/validation";
 import { Application } from "@mainsail/kernel";
 import { describe } from "@mainsail/test-runner";
+import { Contracts } from "@mainsail/contracts";
 import { schemas } from "../validation/index.js";
 import { EthGetCodeAction } from "./index.js";
 
 describe<{
 	app: Application;
 	action: EthGetCodeAction;
-	validator: Validator;
+	validator: Contracts.Crypto.Validator;
 	evm: any;
 }>("EthGetCodeAction", ({ beforeEach, it, assert }) => {
 	beforeEach(async (context) => {
@@ -19,10 +19,12 @@ describe<{
 		};
 
 		context.app = new Application();
+
+		await context.app.resolve(ValidationServiceProvider).register();
 		context.app.bind(Identifiers.Evm.Instance).toConstantValue(context.evm);
 
 		context.action = context.app.resolve(EthGetCodeAction);
-		context.validator = context.app.resolve(Validator);
+		context.validator = context.app.get<Contracts.Crypto.Validator>(Identifiers.Cryptography.Validator);
 	});
 
 	it("should have a name", ({ action }) => {
@@ -31,7 +33,6 @@ describe<{
 
 	it("schema should be ok", ({ action, validator }) => {
 		validator.addSchema(keccak256Schemas.address);
-		validator.addSchema(validationSchemas.prefixedQuantityHex);
 		validator.addSchema(schemas.blockTag);
 		validator.addSchema(action.schema);
 

packages/api-evm/source/actions/eth-get-storage-at.test.ts

@@ -1,28 +1,30 @@
 import { Identifiers } from "@mainsail/constants";
 import { schemas as keccak256Schemas } from "@mainsail/crypto-address-keccak256";
-import { schemas as validationSchemas } from "@mainsail/crypto-validation";
-import { Validator } from "@mainsail/validation";
+import { ServiceProvider as ValidationServiceProvider } from "@mainsail/validation";
 import { Application } from "@mainsail/kernel";
 import { describe } from "@mainsail/test-runner";
+import { Contracts } from "@mainsail/contracts";
 import { schemas } from "../validation/index.js";
 import { EthGetStorageAtAction } from "./index.js";
 
 describe<{
 	app: Application;
 	action: EthGetStorageAtAction;
-	validator: Validator;
+	validator: Contracts.Crypto.Validator;
 	evm: any;
-}>("EthGetCodeAction", ({ beforeEach, it, assert, spy }) => {
+}>("EthGetStorageAtAction", ({ beforeEach, it, assert, spy }) => {
 	beforeEach(async (context) => {
 		context.evm = {
 			storageAt: () => "0x0",
 		};
 
 		context.app = new Application();
+
+		await context.app.resolve(ValidationServiceProvider).register();
 		context.app.bind(Identifiers.Evm.Instance).toConstantValue(context.evm);
 
 		context.action = context.app.resolve(EthGetStorageAtAction);
-		context.validator = context.app.resolve(Validator);
+		context.validator = context.app.get<Contracts.Crypto.Validator>(Identifiers.Cryptography.Validator);
 	});
 
 	it("should have a name", ({ action }) => {
@@ -31,7 +33,6 @@ describe<{
 
 	it("schema should be ok", ({ action, validator }) => {
 		validator.addSchema(keccak256Schemas.address);
-		validator.addSchema(validationSchemas.prefixedQuantityHex);
 		validator.addSchema(schemas.blockTag);
 		validator.addSchema(action.schema);
 

packages/api-evm/source/actions/eth-get-transaction-count.test.ts

@@ -1,16 +1,16 @@
 import { Identifiers } from "@mainsail/constants";
 import { schemas as keccak256Schemas } from "@mainsail/crypto-address-keccak256";
-import { schemas as validationSchemas } from "@mainsail/crypto-validation";
-import { Validator } from "@mainsail/validation";
+import { ServiceProvider as ValidationServiceProvider } from "@mainsail/validation";
 import { Application } from "@mainsail/kernel";
 import { describe } from "@mainsail/test-runner";
+import { Contracts } from "@mainsail/contracts";
 import { schemas } from "../validation/index.js";
 import { EthGetTransactionCount } from "./index.js";
 
 describe<{
 	app: Application;
 	action: EthGetTransactionCount;
-	validator: Validator;
+	validator: Contracts.Crypto.Validator;
 	evm: any;
 }>("EthGetTransactionCount", ({ beforeEach, it, assert }) => {
 	const balance = BigInt(0);
@@ -25,10 +25,11 @@ describe<{
 		};
 
 		context.app = new Application();
+		await context.app.resolve(ValidationServiceProvider).register();
 		context.app.bind(Identifiers.Evm.Instance).toConstantValue(context.evm);
 
 		context.action = context.app.resolve(EthGetTransactionCount);
-		context.validator = context.app.resolve(Validator);
+		context.validator = context.app.get<Contracts.Crypto.Validator>(Identifiers.Cryptography.Validator);
 	});
 
 	it("should have a name", ({ action }) => {
@@ -37,7 +38,6 @@ describe<{
 
 	it("schema should be array with 0 parameters", ({ action, validator }) => {
 		validator.addSchema(keccak256Schemas.address);
-		validator.addSchema(validationSchemas.prefixedQuantityHex);
 		validator.addSchema(schemas.blockTag);
 		validator.addSchema(action.schema);
 

packages/api-evm/source/actions/web3-sha3.test.ts

@@ -1,32 +1,31 @@
 import { Identifiers } from "@mainsail/constants";
-import { Validator } from "@mainsail/validation";
-import { schemas as cryptoValidationSchemas } from "@mainsail/crypto-validation";
+import { ServiceProvider as ValidationServiceProvider } from "@mainsail/validation";
 import { Application } from "@mainsail/kernel";
 import { describe } from "@mainsail/test-runner";
+import { Contracts } from "@mainsail/contracts";
 import { Web3Sha3 } from "./index.js";
 
 describe<{
 	app: Application;
 	action: Web3Sha3;
-	validator: Validator;
+	validator: Contracts.Crypto.Validator;
 }>("Web3Sha3", ({ beforeEach, it, assert }) => {
 	const version = "0.0.1";
 
 	beforeEach(async (context) => {
 		context.app = new Application();
+		await context.app.resolve(ValidationServiceProvider).register();
 		context.app.bind(Identifiers.Application.Version).toConstantValue(version);
 
 		context.action = context.app.resolve(Web3Sha3);
-		context.validator = context.app.resolve(Validator);
+		context.validator = context.app.get<Contracts.Crypto.Validator>(Identifiers.Cryptography.Validator);
 	});
 
 	it("should have a name", ({ action }) => {
 		assert.equal(action.name, "web3_sha3");
 	});
 
 	it("schema should be ok", ({ action, validator }) => {
-		validator.addSchema(cryptoValidationSchemas.prefixedQuantityHex);
-
 		assert.equal(action.schema, {
 			$id: `jsonRpc_web3_sha3`,
 			maxItems: 1,

packages/api-http/source/controllers/node.ts

@@ -86,7 +86,6 @@ export class NodeController extends Controller {
 				explorer: network.client.explorer,
 				nethash: network.nethash,
 				ports: this.buildPortMapping(plugins),
-				slip44: network.slip44,
 				symbol: network.client.symbol,
 				token: network.client.token,
 				version: network.pubKeyHash,