chore(transactions): remove unused index parameter (#1266)

* remove unused `index` parameter

* empty commit

Author: oXtxNt9U

packages/contracts/source/contracts/evm/evm.ts

@@ -118,7 +118,6 @@ export interface TransactionContext {
 	readonly data: Buffer;
 	readonly blockContext: BlockContext;
 	readonly txHash: string;
-	readonly index?: number;
 	readonly specId: SpecId;
 }
 

packages/contracts/source/contracts/processor/transaction-processor.ts

@@ -3,5 +3,5 @@ import type { TransactionReceipt } from "../evm/index.js";
 import type { ProcessableUnit } from "./processable-unit.js";
 
 export interface TransactionProcessor {
-	process(unit: ProcessableUnit, transaction: Transaction, index: number): Promise<TransactionReceipt>;
+	process(unit: ProcessableUnit, transaction: Transaction): Promise<TransactionReceipt>;
 }

packages/contracts/source/contracts/transactions.ts

@@ -16,7 +16,7 @@ export interface TransactionHandler {
 
 	throwIfCannotBeApplied(transaction: Transaction, sender: Wallet, evm: Instance): Promise<void>;
 
-	apply(context: TransactionHandlerContext, transaction: Transaction, index: number): Promise<TransactionReceipt>;
+	apply(context: TransactionHandlerContext, transaction: Transaction): Promise<TransactionReceipt>;
 }
 
 export interface TransactionHandlerRegistry {
@@ -46,11 +46,7 @@ export interface TransactionValidatorContext {
 
 export interface TransactionValidator {
 	getEvm(): Instance;
-	validate(
-		context: TransactionValidatorContext,
-		transaction: Transaction,
-		index: number,
-	): Promise<TransactionReceipt>;
+	validate(context: TransactionValidatorContext, transaction: Transaction): Promise<TransactionReceipt>;
 }
 
 export type TransactionValidatorFactory = () => TransactionValidator;

packages/processor/source/block-processor.ts

@@ -78,7 +78,7 @@ export class BlockProcessor implements Contracts.Processor.BlockProcessor {
 					await sleep(0);
 				}
 
-				const receipt = await this.transactionProcessor.process(unit, transaction, index);
+				const receipt = await this.transactionProcessor.process(unit, transaction);
 				processResult.receipts.set(transaction.hash, receipt);
 
 				this.#consumeGas(block, processResult, Number(receipt.gasUsed));

packages/processor/source/transaction-processor.ts

@@ -29,7 +29,6 @@ export class TransactionProcessor implements Contracts.Processor.TransactionProc
 	async process(
 		unit: Contracts.Processor.ProcessableUnit,
 		transaction: Contracts.Crypto.Transaction,
-		index: number,
 	): Promise<Contracts.Evm.TransactionReceipt> {
 		const block = unit.getBlock();
 
@@ -57,7 +56,7 @@ export class TransactionProcessor implements Contracts.Processor.TransactionProc
 			throw new InvalidSignatureError();
 		}
 
-		const receipt = await this.transactionHandler.apply(transactionHandlerContext, transaction, index);
+		const receipt = await this.transactionHandler.apply(transactionHandlerContext, transaction);
 
 		const feeConsumed = this.feeCalculator.calculateConsumed(transaction.gasPrice, Number(receipt.gasUsed));
 		this.logger.debug(

packages/transactions/source/handlers/transaction.ts

@@ -71,7 +71,6 @@ export class TransactionHandler implements Contracts.Transactions.TransactionHan
 	public async apply(
 		context: Contracts.Transactions.TransactionHandlerContext,
 		transaction: Contracts.Crypto.Transaction,
-		index: number,
 	): Promise<Contracts.Evm.TransactionReceipt> {
 		assert.string(transaction.hash);
 
@@ -85,7 +84,6 @@ export class TransactionHandler implements Contracts.Transactions.TransactionHan
 				from: transaction.from,
 				gasLimit: BigInt(transaction.gasLimit),
 				gasPrice: BigInt(transaction.gasPrice),
-				index,
 				legacyAddress: transaction.senderLegacyAddress,
 				nonce: transaction.nonce.toBigInt(),
 				specId: evmSpec,

packages/transactions/source/transaction-validator.ts

@@ -24,7 +24,6 @@ export class TransactionValidator implements Contracts.Transactions.TransactionV
 	public async validate(
 		context: Contracts.Transactions.TransactionValidatorContext,
 		transaction: Contracts.Crypto.Transaction,
-		index: number,
 	): Promise<Contracts.Evm.TransactionReceipt> {
 		const deserialized: Contracts.Crypto.Transaction = await this.transactionFactory.fromBytes(
 			transaction.serialized,
@@ -46,7 +45,6 @@ export class TransactionValidator implements Contracts.Transactions.TransactionV
 				},
 			},
 			transaction,
-			index,
 		);
 
 		assert.string(transaction.from);

packages/validator/source/validator.ts

@@ -174,7 +174,7 @@ export class Validator implements Contracts.Validator.Validator {
 				performance.now() +
 				milestone.timeouts.blockPrepareTime * this.configuration.getRequired<number>("txCollatorFactor");
 
-			for (const [index, bytes] of transactionBytes.entries()) {
+			for (const bytes of transactionBytes.values()) {
 				if (performance.now() > timeLimit) {
 					break;
 				}
@@ -210,7 +210,6 @@ export class Validator implements Contracts.Validator.Validator {
 					const result = await validator.validate(
 						{ commitKey, gasLimit: milestone.block.maxGasLimit, generatorAddress, timestamp },
 						transaction,
-						index,
 					);
 
 					gasLeft -= Number(result.gasUsed);

tests/functional/consensus/source/custom-proposal.ts

@@ -61,7 +61,7 @@ export const makeCustomProposal = async (
 	const transactionData: Contracts.Crypto.TransactionData[] = [];
 	let payloadSize = 2;
 
-	for (const [index,transaction] of transactions.entries()) {
+	for (const transaction of transactions.values()) {
 		let result = { gasRefunded: 0n, gasUsed: 0n, logs: [] as any, status: 0 };
 
 		try {
@@ -73,7 +73,6 @@ export const makeCustomProposal = async (
 					timestamp: dayjs().valueOf(),
 				},
 				transaction,
-				index,
 			);
 		} catch {
 			result = { ...result, gasUsed: BigInt(transaction.gasLimit) };
@@ -129,14 +128,12 @@ export const makeCustomProposal = async (
 		lockProof: undefined,
 	});
 
-	const serializedProposal = await messageSerializer.serializeProposalUnsigned(
-		{
-			payloadSerialized:  proposedBytes.toString("hex"),
-			round,
-			validRound: undefined,
-			validatorIndex: 0,
-		},
-	);
+	const serializedProposal = await messageSerializer.serializeProposalUnsigned({
+		payloadSerialized: proposedBytes.toString("hex"),
+		round,
+		validRound: undefined,
+		validatorIndex: 0,
+	});
 
 	const proposalSignature = await app
 		.getTagged<Contracts.Crypto.SignatureBls>(Identifiers.Cryptography.Signature.Instance, "type", "consensus")
@@ -158,7 +155,11 @@ export const makeCustomProposal = async (
 	return proposal;
 };
 
-export const makeTransactionBuilderContext = (app: Contracts.Kernel.Application, apps: Contracts.Kernel.Application[], validators: Validator[]) => {
+export const makeTransactionBuilderContext = (
+	app: Contracts.Kernel.Application,
+	apps: Contracts.Kernel.Application[],
+	validators: Validator[],
+) => {
 	const context = {
 		app,
 		wallets: validators.map((v) => ({