Skip to content

fix: improve WIF support#1263

Merged
sebastijankuzner merged 23 commits into
developfrom
test/wif/fix-tests
Apr 3, 2026
Merged

fix: improve WIF support#1263
sebastijankuzner merged 23 commits into
developfrom
test/wif/fix-tests

Conversation

@sebastijankuzner
Copy link
Copy Markdown
Contributor

@sebastijankuzner sebastijankuzner commented Mar 30, 2026

Summary

Fix WIF. Remove support on crypto-key-pair-bls12-381.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.45%. Comparing base (07b0d04) to head (339b65c).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/exceptions/source/crypto.ts 0.00% 6 Missing ⚠️
packages/crypto-key-pair-bls12-381/source/pair.ts 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1263      +/-   ##
===========================================
+ Coverage    53.16%   53.45%   +0.29%     
===========================================
  Files         1128     1131       +3     
  Lines        63677    64105     +428     
  Branches      1723     1801      +78     
===========================================
+ Hits         33854    34269     +415     
- Misses       29531    29541      +10     
- Partials       292      295       +3     
Flag Coverage Δ
contracts 98.60% <ø> (?)
packages 53.15% <81.57%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sebastijankuzner sebastijankuzner marked this pull request as ready for review April 2, 2026 19:49
@sebastijankuzner sebastijankuzner changed the title test: fix fromWIF tests test: fix WIF tests Apr 2, 2026
@sebastijankuzner sebastijankuzner changed the title test: fix WIF tests fix: improve WIF support Apr 2, 2026
@sebastijankuzner sebastijankuzner merged commit 3cf38fa into develop Apr 3, 2026
40 of 41 checks passed
@sebastijankuzner sebastijankuzner deleted the test/wif/fix-tests branch April 3, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants