Skip to content

refactor: rename active validators to round validators#969

Merged
sebastijankuzner merged 16 commits into
developfrom
feat/contracts/rename-active-to-round
Jun 4, 2025
Merged

refactor: rename active validators to round validators#969
sebastijankuzner merged 16 commits into
developfrom
feat/contracts/rename-active-to-round

Conversation

@sebastijankuzner
Copy link
Copy Markdown
Contributor

@sebastijankuzner sebastijankuzner commented Jun 3, 2025

Summary

Use new naming structure:

  • Registered validators -> All validators that are registered including resigned validators
  • Round validators -> Top N validators with the highest vote balance, that participate in the consensus
  • Resigned validators -> Validators that resigned from the consensus
  • Active validators -> Round validators that are not resigned and have a valid BLS public key
  • Inactive validators -> Validators that are resigned or do not have a valid BLS public key

Checklist

  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 52.12766% with 90 lines in your changes missing coverage. Please review.

Project coverage is 50.45%. Comparing base (4de3046) to head (b6d1bc8).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
packages/evm/bindings/src/lib.rs 0.00% 16 Missing ⚠️
packages/evm-consensus/source/validator-set.ts 0.00% 13 Missing ⚠️
packages/consensus/source/round-state.ts 0.00% 9 Missing ⚠️
...ckages/p2p/source/downloader/message-downloader.ts 0.00% 7 Missing ⚠️
packages/consensus/source/aggregator.ts 0.00% 5 Missing ⚠️
...ckages/api-development/source/controllers/round.ts 0.00% 4 Missing ⚠️
packages/api-sync/source/service.ts 0.00% 4 Missing ⚠️
...nsus/source/services/consensus-contract-service.ts 0.00% 4 Missing ⚠️
packages/evm/bindings/src/ctx.rs 0.00% 4 Missing ⚠️
...es/consensus/source/processors/commit-processor.ts 0.00% 3 Missing ⚠️
... and 11 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #969      +/-   ##
===========================================
+ Coverage    50.25%   50.45%   +0.20%     
===========================================
  Files         1112     1112              
  Lines        60076    60099      +23     
  Branches      1458     1467       +9     
===========================================
+ Hits         30190    30325     +135     
+ Misses       29848    29736     -112     
  Partials        38       38              
Flag Coverage Δ
contracts 99.48% <100.00%> (ø)
packages 50.13% <37.93%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sebastijankuzner sebastijankuzner marked this pull request as draft June 3, 2025 17:39
@sebastijankuzner sebastijankuzner marked this pull request as ready for review June 4, 2025 10:21
@sebastijankuzner sebastijankuzner merged commit a1215b5 into develop Jun 4, 2025
18 checks passed
@sebastijankuzner sebastijankuzner deleted the feat/contracts/rename-active-to-round branch June 4, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant