Skip to content

feat(contracts): collect validator registration fee#970

Merged
sebastijankuzner merged 36 commits into
developfrom
feat/contracts/validator-fee
Jun 12, 2025
Merged

feat(contracts): collect validator registration fee#970
sebastijankuzner merged 36 commits into
developfrom
feat/contracts/validator-fee

Conversation

@sebastijankuzner
Copy link
Copy Markdown
Contributor

@sebastijankuzner sebastijankuzner commented Jun 5, 2025

Summary

Collect validators fee on validator registration. Fee, can be set via milestone. Fee is returned to validator if validator resigns.

Checklist

  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 75.23810% with 26 lines in your changes missing coverage. Please review.

Project coverage is 50.45%. Comparing base (4de3046) to head (ce76a99).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
packages/evm-consensus/source/index.ts 0.00% 14 Missing ⚠️
packages/evm-consensus/source/deployer.ts 0.00% 7 Missing ⚠️
...nsus/source/services/consensus-contract-service.ts 0.00% 4 Missing ⚠️
...ration-generator/source/configuration-generator.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #970      +/-   ##
===========================================
+ Coverage    50.25%   50.45%   +0.20%     
===========================================
  Files         1112     1112              
  Lines        60076    60211     +135     
  Branches      1458     1476      +18     
===========================================
+ Hits         30190    30379     +189     
+ Misses       29848    29794      -54     
  Partials        38       38              
Flag Coverage Δ
contracts 98.63% <100.00%> (-0.86%) ⬇️
packages 50.10% <36.58%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sebastijankuzner sebastijankuzner marked this pull request as ready for review June 5, 2025 19:56
Comment thread contracts/src/consensus/ConsensusV1.sol Outdated
Comment thread contracts/src/consensus/ConsensusV1.sol Outdated
Comment thread contracts/src/consensus/ConsensusV1.sol
Comment thread contracts/src/consensus/ConsensusV1.sol
Comment thread contracts/src/consensus/ConsensusV1.sol Outdated
Comment thread contracts/src/consensus/ConsensusV1.sol Outdated
@oXtxNt9U oXtxNt9U force-pushed the feat/contracts/validator-fee branch 2 times, most recently from ffca172 to b43625a Compare June 11, 2025 04:56
@sebastijankuzner sebastijankuzner force-pushed the feat/contracts/validator-fee branch from 52b3385 to 7d16611 Compare June 11, 2025 16:41
@oXtxNt9U oXtxNt9U force-pushed the feat/contracts/validator-fee branch 2 times, most recently from a7a3edf to c85b3d5 Compare June 12, 2025 01:09
@oXtxNt9U oXtxNt9U force-pushed the feat/contracts/validator-fee branch from 8670c5a to a3f03c4 Compare June 12, 2025 01:50
@sebastijankuzner sebastijankuzner merged commit 299ddbd into develop Jun 12, 2025
18 checks passed
@sebastijankuzner sebastijankuzner deleted the feat/contracts/validator-fee branch June 12, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants