Skip to content

refactor(consensus): keep registration fee stored after resignation #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastijankuzner merged 4 commits into from
Jun 20, 2025
Merged

refactor(consensus): keep registration fee stored after resignation #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
803b477
keep paid fee on validator
oXtxNt9U Jun 20, 2025
51379bf
fix test
oXtxNt9U Jun 20, 2025
ba9f915
update ABI
oXtxNt9U Jun 20, 2025
5df436c
style: resolve style guide violations
oXtxNt9U Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions contracts/src/consensus/ConsensusV1.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,7 @@ contract ConsensusV1 is UUPSUpgradeable, OwnableUpgradeable {

// Refund the registration fee to the validator
if (validator.fee > 0) {
uint256 refundFee = validator.fee;
validator.fee = 0;
(bool success,) = payable(msg.sender).call{value: refundFee}("");
(bool success,) = payable(msg.sender).call{value: validator.fee}("");
if (!success) {
revert RefundFailed();
}
Expand Down
4 changes: 2 additions & 2 deletions contracts/test/consensus/Consensus-ValidatorResignation.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ contract ConsensusTest is Base {
assertEq(validator.data.blsPublicKey, prepareBLSKey(addr));
assertEq(validator.data.voteBalance, 0);
assertEq(validator.data.votersCount, 0);
assertEq(validator.data.fee, 0);
assertEq(validator.data.fee, customFee); // Fee does not get reset
assertEq(validator.data.isResigned, true);
assertEq(addr.balance, 100 ether);
}
Expand Down Expand Up @@ -177,7 +177,7 @@ contract ConsensusTest is Base {
consensus.resignValidator();
}

function test_validator_resignation_revert_if_bellow_min_validators() public {
function test_validator_resignation_revert_if_below_min_validators() public {
assertEq(consensus.validatorsCount(), 0);
address addr = address(1);

Expand Down
Loading
Loading