refactor: create network objects instead of reading from config.ini (#55)

* refactor: create network objects instead of reading from config.ini
* chore: bump client version + log the change

Author: roks0n

CHANGELOG.md

@@ -7,5 +7,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## Unreleased
 
+## 0.1.1 - 2018-08-29
+
+### Fixed
+
+- created network objects instead of loading network settings from an ini file which is not included in the built package
+
 ## 0.1.0 - 2018-08-27
 - Initial Release

config.ini

@@ -1,26 +1,19 @@
-import os
-from configparser import ConfigParser
-from datetime import datetime
-
-config_file = os.path.abspath('config.ini')
-
-settings = ConfigParser()
-settings.read(config_file)
+from crypto.networks.devnet import Devnet
 
 network = {}
 
 
-def set_network(network_name):
+def set_network(network_object):
     """Set what network you want to use in the crypto library
 
     Args:
-        network_name (str): name of a network, default ones are ARK's mainnet, devnet & testnet
+        network_object (Network object): Testnet, Devnet, Mainnet
     """
     global network
     network = {
-        'epoch': datetime.strptime(settings.get(network_name, 'epoch'), '%Y-%m-%d %H:%M:%S'),
-        'version': int(settings.get(network_name, 'version')),
-        'wif': int(settings.get(network_name, 'wif')),
+        'epoch': network_object.epoch,
+        'version': network_object.version,
+        'wif': network_object.wif,
     }
 
 
@@ -31,7 +24,7 @@ def get_network():
         dict: network settings (default network is devnet)
     """
     if not network:
-        set_network('devnet')
+        set_network(Devnet)
     return network
 
 
@@ -43,10 +36,9 @@ def set_custom_network(epoch, version, wif):
         version (int): chains version
         wif (int): chains wif
     """
-    section_name = 'custom'
-    if section_name not in settings.sections():
-        settings.add_section(section_name)
-    settings.set(section_name, 'epoch', epoch.strftime('%Y-%m-%d %H:%M:%S'))
-    settings.set(section_name, 'version', str(version))
-    settings.set(section_name, 'wif', str(wif))
-    set_network('custom')
+    global network
+    network = {
+        'epoch': epoch,
+        'version': version,
+        'wif': wif,
+    }

crypto/configuration/network.py

@@ -0,0 +1,7 @@
+from datetime import datetime
+
+
+class Devnet(object):
+    epoch = datetime(2017, 3, 21, 13, 00, 00)
+    version = 30
+    wif = 170

crypto/networks/__init__.py

@@ -0,0 +1,7 @@
+from datetime import datetime
+
+
+class Mainnet(object):
+    epoch = datetime(2017, 3, 21, 13, 00, 00)
+    version = 23
+    wif = 170

crypto/networks/devnet.py

@@ -0,0 +1,7 @@
+from datetime import datetime
+
+
+class Testnet(object):
+    epoch = datetime(2017, 3, 21, 13, 00, 00)
+    version = 23
+    wif = 186

crypto/networks/mainnet.py

@@ -28,7 +28,7 @@
 setuptools.setup(
     name='arkecosystem-crypto',
     description='A simple Cryptography Implementation in Python for the ARK Blockchain.',
-    version='0.1.0',
+    version='0.1.1',
     author='Ark Ecosystem',
     author_email='info@ark.io',
     url='https://github.com/ArkEcosystem/python-crypto',

crypto/networks/testnet.py

@@ -1,6 +1,8 @@
 from datetime import datetime
 
 from crypto.configuration.network import get_network, set_custom_network, set_network
+from crypto.networks.devnet import Devnet
+from crypto.networks.mainnet import Mainnet
 
 
 def test_get_network():
@@ -9,10 +11,10 @@ def test_get_network():
 
 
 def test_set_network():
-    set_network('mainnet')
+    set_network(Mainnet)
     result = get_network()
     assert result['version'] == 23
-    set_network('devnet')  # set back to devnet so other tests don't fail
+    set_network(Devnet)  # set back to devnet so other tests don't fail
 
 
 def test_set_custom_network():
@@ -22,4 +24,4 @@ def test_set_custom_network():
     assert result['version'] == 11
     assert result['wif'] == 130
     assert result['epoch'] == epoch_time
-    set_network('devnet')  # set back to devnet so other tests don't fail
+    set_network(Devnet)  # set back to devnet so other tests don't fail