chore: remove deprecated endpoints (#152)

faustbrian · web-flow · commit 872dc89bc34e · 2021-03-23T05:03:16.000+02:00
diff --git a/__tests__/mocks/blocks.ts b/__tests__/mocks/blocks.ts
@@ -30,10 +30,4 @@ export const mockBlocks = (host: string) => {
 		.reply(200, {
 			data: [],
 		});
-
-	nock(host)
-		.post("/blocks/search")
-		.reply(200, {
-			data: [],
-		});
 };
diff --git a/__tests__/mocks/delegates.ts b/__tests__/mocks/delegates.ts
@@ -16,9 +16,4 @@ export const mockDelegates = (host: string) => {
 	nock(host)
 		.get("/delegates/123/voters")
 		.reply(200, { data: [] });
-
-
-	nock(host)
-		.post("/delegates/search")
-		.reply(200, { data: [] });
 };
diff --git a/__tests__/mocks/locks.ts b/__tests__/mocks/locks.ts
@@ -13,12 +13,6 @@ export const mockLocks = (host: string) => {
       data: [],
     });
 
-  nock(host)
-    .post("/locks/search")
-    .reply(200, {
-      data: [],
-    });
-
   nock(host)
     .post("/locks/unlocked")
     .reply(200, {
diff --git a/__tests__/mocks/transactions.ts b/__tests__/mocks/transactions.ts
@@ -21,10 +21,6 @@ export const mockTransactions = (host: string) => {
 		.get("/transactions/unconfirmed/123")
 		.reply(200, { data: [] });
 
-	nock(host)
-		.post("/transactions/search")
-		.reply(200, { data: [] });
-
 	nock(host)
 		.get("/transactions/types")
 		.reply(200, { data: [] });
diff --git a/__tests__/mocks/wallets.ts b/__tests__/mocks/wallets.ts
@@ -29,10 +29,6 @@ export const mockWallets = (host: string) => {
 		.get("/wallets/top")
 		.reply(200, { data: [] });
 
-	nock(host)
-		.post("/wallets/search")
-		.reply(200, { data: [] });
-
 	nock(host)
 		.get("/wallets/123/locks")
 		.reply(200, { data: [] });
diff --git a/__tests__/resources/blocks.test.ts b/__tests__/resources/blocks.test.ts
@@ -33,10 +33,4 @@ describe("API - 2.0 - Resources - Blocks", () => {
 
 		expect(response.status).toBe(200);
 	});
-
-	it("should call \"search\" method", async () => {
-		const response = await resource.search({});
-
-		expect(response.status).toBe(200);
-	});
 });
diff --git a/__tests__/resources/delegates.test.ts b/__tests__/resources/delegates.test.ts
@@ -21,10 +21,4 @@ describe("API - 2.0 - Resources - Delegates", () => {
 
 		expect(response.status).toBe(200);
 	});
-
-	it("should call \"search\" method", async () => {
-		const response = await resource.search({});
-
-		expect(response.status).toBe(200);
-	});
 });
diff --git a/__tests__/resources/locks.test.ts b/__tests__/resources/locks.test.ts
@@ -16,12 +16,6 @@ describe("API - 2.0 - Resources - Locks", () => {
     expect(response.status).toBe(200);
   });
 
-  it("should call \"search\" method", async () => {
-    const response = await resource.search({});
-
-    expect(response.status).toBe(200);
-  });
-
   it("should call \"unlocked\" method", async () => {
     const response = await resource.unlocked({});
 
diff --git a/__tests__/resources/transactions.test.ts b/__tests__/resources/transactions.test.ts
@@ -34,12 +34,6 @@ describe("API - 2.0 - Resources - Transactions", () => {
 		expect(response.status).toBe(200);
 	});
 
-	it("should call \"search\" method", async () => {
-		const response = await resource.search({});
-
-		expect(response.status).toBe(200);
-	});
-
 	it("should call \"types\" method", async () => {
 		const response = await resource.types();
 
diff --git a/__tests__/resources/wallets.test.ts b/__tests__/resources/wallets.test.ts
@@ -46,12 +46,6 @@ describe("API - 2.0 - Resources - Wallets", () => {
 		expect(response.status).toBe(200);
 	});
 
-	it("should call \"search\" method", async () => {
-		const response = await resource.search({});
-
-		expect(response.status).toBe(200);
-	});
-
 	it("should call \"locks\" method", async () => {
 		const response = await resource.locks("123");
 
diff --git a/src/resources/blocks.ts b/src/resources/blocks.ts
@@ -1,8 +1,7 @@
-import { ApiQuery, ApiResponse, ApiResponseWithPagination } from "../interfaces";
+import { ApiResponse, ApiResponseWithPagination } from "../interfaces";
 import { Resource } from "./resource";
 import {
 	AllBlockApiQuery,
-	SearchBlockApiBody,
 	TransactionsInBlockApiQuery,
 	Block,
 	Transaction,
@@ -64,15 +63,4 @@ export class Blocks extends Resource {
 	): Promise<ApiResponseWithPagination<Transaction[]>> {
 		return this.sendGet(`blocks/${idOrHeight}/transactions`, query);
 	}
-
-	/**
-	 * Search All Blocks
-	 *
-	 * It is possible to filter for specifics blocks using the search resource.
-	 *
-	 * Filtering for blocks at the Node side is a lot more efficient than requesting a large payload and filtering it at the client side.
-	 */
-	public async search(payload?: SearchBlockApiBody, query?: ApiQuery): Promise<ApiResponseWithPagination<Block[]>> {
-		return this.sendPost("blocks/search", payload, query);
-	}
 }
diff --git a/src/resources/delegates.ts b/src/resources/delegates.ts
@@ -1,9 +1,8 @@
-import { ApiQuery, ApiResponse, ApiResponseWithPagination } from "../interfaces";
+import { ApiResponse, ApiResponseWithPagination } from "../interfaces";
 import {
 	AllDelegatesApiQuery,
 	DelegateBlocksApiQuery,
 	DelegateVotersApiQuery,
-	SearchDelegatesApiBody,
 	Delegate,
 	Voter,
 } from "../resourcesTypes/delegates";
@@ -72,13 +71,4 @@ export class Delegates extends Resource {
 	): Promise<ApiResponseWithPagination<Voter[]>> {
 		return this.sendGet(`delegates/${usernameOrAddressOrPublicKey}/voters`, query);
 	}
-
-	/**
-	 * Search for a Delegate
-	 *
-	 * For fine-grained searches, use the search endpoint.
-	 */
-	public async search(payload?: SearchDelegatesApiBody, query?: ApiQuery): Promise<ApiResponseWithPagination<Delegate[]>> {
-		return this.sendPost("delegates/search", payload, query);
-	}
 }
diff --git a/src/resources/locks.ts b/src/resources/locks.ts
@@ -1,8 +1,6 @@
 import { ApiResponse, ApiResponseWithPagination } from "../interfaces";
 import {
 	AllLocksApiQuery,
-	SearchLocksApiBody,
-	SearchLocksApiQuery,
 	SearchLocksUnlockedApiBody,
 	SearchLocksUnlockedApiQuery,
 	Lock,
@@ -29,16 +27,6 @@ export class Locks extends Resource {
 		return this.sendGet(`locks/${id}`);
 	}
 
-	/**
-	 * Search locks
-	 */
-	public async search(
-		payload?: SearchLocksApiBody,
-		query?: SearchLocksApiQuery,
-	): Promise<ApiResponseWithPagination<Lock[]>> {
-		return this.sendPost("locks/search", payload, query);
-	}
-
 	/**
 	 * Search unlocked
 	 */
diff --git a/src/resources/transactions.ts b/src/resources/transactions.ts
@@ -1,7 +1,6 @@
 import { ApiQuery, ApiResponse, ApiResponseWithPagination } from "../interfaces";
 import {
 	AllTransactionsApiQuery,
-	SearchTransactionsApiBody,
 	CreateTransactionApiResponse,
 	Transaction,
 	TransactionTypes,
@@ -72,22 +71,6 @@ export class Transactions extends Resource {
 		return this.sendGet(`transactions/unconfirmed/${id}`);
 	}
 
-	/**
-	 * Search for Transactions
-	 *
-	 * For fine-grained searches, use the `search` endpoint.
-	 *
-	 * Note that unless you use specific body parameters, the response might contain a large number of transactions (hundreds of thousands).
-	 *
-	 * It is best to filter as many transactions node side, instead of dissecting the response client side.
-	 */
-	public async search(
-		payload: SearchTransactionsApiBody,
-		query?: ApiQuery,
-	): Promise<ApiResponseWithPagination<Transaction[]>> {
-		return this.sendPost("transactions/search", payload, query);
-	}
-
 	/**
 	 * Get Transaction Types
 	 *
diff --git a/src/resources/wallets.ts b/src/resources/wallets.ts
@@ -1,7 +1,6 @@
 import { ApiQuery, ApiResponse, ApiResponseWithPagination } from "../interfaces";
 import {
 	AllWalletsApiQuery,
-	SearchWalletsApiBody,
 	WalletsTransactionsApiQuery,
 	WalletsTransactionsReceivedApiQuery,
 	WalletsTransactionsSentApiQuery,
@@ -108,17 +107,6 @@ export class Wallets extends Resource {
 		return this.sendGet("wallets/top", query);
 	}
 
-	/**
-	 * Search All Wallets
-	 *
-	 * Searching for specific wallets is possible as well.
-	 *
-	 * A direct database query usually is more performant when the query expression becomes complicated.
-	 */
-	public async search(payload: SearchWalletsApiBody, query?: ApiQuery): Promise<ApiResponseWithPagination<Wallet[]>> {
-		return this.sendPost("wallets/search", payload, query);
-	}
-
 	/**
 	 * List All Locks of a Wallet
 	 *
diff --git a/src/resourcesTypes/blocks.ts b/src/resourcesTypes/blocks.ts
@@ -1,4 +1,4 @@
-import { ApiBody, ApiQuery } from "../interfaces";
+import { ApiQuery } from "../interfaces";
 
 export interface Block {
 	id: string;
@@ -65,67 +65,3 @@ export interface TransactionsInBlockApiQuery extends ApiQuery {
 	fee?: number;
 	vendorField?: string;
 }
-
-export interface SearchBlockApiBody extends ApiBody {
-	/** ID of the block. */
-	id?: string;
-	/** Version of the block. */
-	version?: number;
-	/** ID of the previous block. */
-	previousBlock?: number;
-	/** Hash of the payload. */
-	payloadHash?: string;
-	/** Public key of the forger who forged the block. */
-	generatorPublicKey?: string;
-	/** Signature of the block. */
-	blockSignature?: string;
-	/** Timestamp range for block creation time. Measured in number of seconds since the genesis block. */
-	timestamp?: {
-		/** Block creation time must be bigger or equal to this. */
-		from?: number;
-		/** Block creation time must be smaller or equal to this. */
-		to?: number;
-	};
-	/** Height range of the block. The genesis block has height 1. */
-	height?: {
-		/** Block height must be bigger or equal to this. */
-		from?: number;
-		/** Block height must be smaller or equal to this. */
-		to?: number;
-	};
-	/** Ranage for number of transactions contained in the block. */
-	numberOfTransactions?: {
-		/** The number of transactions in the block must be bigger or equal to this. */
-		from?: number;
-		/** The number of transactions in the block must be smaller or equal to this. */
-		to?: number;
-	};
-	/** Range for total amount transacted in the block, including block reward, transaction fees and transactions' amounts. In arktoshi. */
-	totalAmount?: {
-		/** Block total amount must be bigger or equal to this. */
-		from?: number;
-		/** Block total amount must be smaller or equal to this. */
-		to?: number;
-	};
-	/** Range for the sum of all transactions' fees in the block. In arktoshi. */
-	totalFee?: {
-		/** The sum of all transactions' fees in the block must be bigger or equal to this. */
-		from?: number;
-		/** The sum of all transactions' fees in the block must be smaller or equal to this. */
-		to?: number;
-	};
-	/** Range for block reward. In arktoshi. */
-	reward?: {
-		/** Block reward must be bigger or equal to this. */
-		from?: number;
-		/** Block reward must be smaller or equal to this. */
-		to?: number;
-	};
-	/** Range for block payload length. In bytes. */
-	payloadLength?: {
-		/** Block payload length must be bigger or equal to this. */
-		from?: number;
-		/** Block payload length must be smaller or equal to this. */
-		to?: number;
-	};
-}
diff --git a/src/resourcesTypes/delegates.ts b/src/resourcesTypes/delegates.ts
@@ -1,4 +1,4 @@
-import { ApiBody, ApiQuery } from "../interfaces";
+import { ApiQuery } from "../interfaces";
 
 export interface Delegate {
 	username: string;
@@ -84,56 +84,3 @@ export interface DelegateVotersApiQuery extends ApiQuery {
 	voteBalance?: number;
 	producedBlocks?: number;
 }
-
-export interface SearchDelegatesApiBody extends ApiBody {
-	/** The address of the delegate to be retrieved. */
-	address?: string;
-	/** The public key of the delegate to be retrieved. */
-	publicKey?: string;
-	/** The username of the delegate to be retrieved. */
-	username?: string;
-	/** The usernames of the delegates to be retrieved. */
-	usernames?: string[];
-	/** The approval rate of the delegates to be retrieved. */
-	approval?: {
-		/** The lower limit of the approval rate. */
-		from?: number;
-		/** The upper limit of the approval rate. */
-		to?: number;
-	};
-	/** The forged fees of the delegates to be retrieved. */
-	forgedFees?: {
-		/** The lower limit of the forged fees. */
-		from?: number;
-		/** The upper limit of the forged fees. */
-		to?: number;
-	};
-	/** The forged rewards of the delegates to be retrieved. */
-	forgedRewards?: {
-		/** The lower limit of the forged rewards. */
-		from?: number;
-		/** The upper limit of the forged rewards. */
-		to?: number;
-	};
-	/** The forged total of the delegates to be retrieved. */
-	forgedTotal?: {
-		/** The lower limit of the forged total. */
-		from?: number;
-		/** The upper limit of the forged total. */
-		to?: number;
-	};
-	/** The produced blocks count of the delegates to be retrieved. */
-	producedBlocks?: {
-		/** The lower limit of the produced blocks count. */
-		from?: number;
-		/** The upper limit of the produced blocks count. */
-		to?: number;
-	};
-	/** The vote balance of the delegates to be retrieved. */
-	voteBalance?: {
-		/** The lower limit of the vote balance. */
-		from?: number;
-		/** The upper limit of the vote balance. */
-		to?: number;
-	};
-}
diff --git a/src/resourcesTypes/locks.ts b/src/resourcesTypes/locks.ts
diff --git a/src/resourcesTypes/transactions.ts b/src/resourcesTypes/transactions.ts
diff --git a/src/resourcesTypes/wallets.ts b/src/resourcesTypes/wallets.ts
