Skip to content

Commit 4c666f8

Browse files
committed
updated based on copilot review
1 parent 5430d93 commit 4c666f8

4 files changed

Lines changed: 12 additions & 8 deletions

File tree

assets/css/cross-page.css

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -189,10 +189,7 @@ arm-top-navigation:not(:defined) {
189189
position: relative;
190190
top: 0;
191191
}
192-
.nav-transparent {
193-
background: var(--ads-ui-ink-100);
194-
background-color: var(--ads-ui-ink-100);
195-
}
192+
.nav-transparent,
196193
.nav-black {
197194
background: var(--ads-ui-ink-100);
198195
background-color: var(--ads-ui-ink-100);

config.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,9 @@ github_project_repo = "https://github.com/ArmDeveloperEcosystem/arm-learning-pat
7373
# location of assets
7474
assetsDir = "assets"
7575

76+
# Optionally override the global web components bundle for a specific deployment.
77+
# global_web_components_url = "https://www.arm.com/arm-global-web-components/devhub/app.js"
78+
7679
# Specify a value here if your content directory is not in your repo's root directory
7780
# github_subdir = ""
7881

themes/arm-design-system-hugo-theme/layouts/partials/head/head.html

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,15 @@
5555
integrity="sha384-caAG7P/HrHxcdQa2gTEfvZYGPLQk7yRwVdvtRn6sa3TRKzcAyY1LMvObXKGhwFNb"
5656
crossorigin="anonymous">
5757
</script>
58-
<!-- Arm Header & Footer loading.
59-
TODO: Replace the test bundle with its production URL when Arm publishes it. -->
58+
<!-- Arm Header & Footer loading. Local development uses the test bundle;
59+
production defaults to stable app.js unless a deployment explicitly overrides it. -->
60+
{{ $globalWebComponentsURL := .Site.Params.global_web_components_url | default "https://www.arm.com/arm-global-web-components/devhub/app.js" }}
61+
{{ if and hugo.IsServer (not .Site.Params.global_web_components_url) }}
62+
{{ $globalWebComponentsURL = "https://www.arm.com/arm-global-web-components/devhub/test.js" }}
63+
{{ end }}
6064
<script
6165
type="text/javascript"
62-
src="https://www.arm.com/arm-global-web-components/devhub/test.js"
66+
src="{{ $globalWebComponentsURL }}"
6367
defer>
6468
</script>
6569

themes/arm-design-system-hugo-theme/static/js/authentication.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ document.addEventListener('arm-account-signin', (event) => {
277277

278278
const signInButton = shadowRoot.querySelector('.c-utility-navigation-login__sign-in-button');
279279
if (signInButton) {
280-
signInButton.innerHTML = "Redirecting...";
280+
signInButton.textContent = "Redirecting...";
281281
}
282282
else {
283283
console.log("Sign-in button not found in DOM.");

0 commit comments

Comments
 (0)