Skip to content

Commit 6397209

Browse files
authored
Merge pull request #3518 from ArmDeveloperEcosystem/adsv5
revert to stable app.js
2 parents 193e279 + dae5a3a commit 6397209

4 files changed

Lines changed: 10 additions & 12 deletions

File tree

assets/css/home.css

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,12 @@ html[theme='dark'] body {
2222
background-image: none;
2323
}
2424

25-
/* CLS fix: lock the breadcrumb masthead height so hydration doesn't shift content below */
25+
/* Match the homepage breadcrumb spacing more closely to category mastheads. */
2626
#only-breadcrumb-masthead {
27-
height: 40px;
27+
box-sizing: border-box;
28+
height: 64px;
2829
overflow: hidden;
30+
padding-top: 24px;
2931
}
3032

3133
/* CLS fix: lock the description+button area height to prevent shift when ads-cta-button hydrates */

config.internal.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
[params]
2-
# Validate the refreshed global navigation and footer on internal.learn.arm.com.
3-
global_web_components_url = "https://www.arm.com/arm-global-web-components/devhub/test.js"
2+
# Use Arm's stable navigation and footer bundle internally.
3+
global_web_components_url = "https://www.arm.com/arm-global-web-components/devhub/app.js"

config.production.toml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
[params]
2-
# Temporary production opt-in for the refreshed global navigation and footer.
3-
# Replace this URL when Arm publishes the refreshed stable bundle.
4-
global_web_components_url = "https://www.arm.com/arm-global-web-components/devhub/test.js"
2+
# Use Arm's stable navigation and footer bundle in production.
3+
global_web_components_url = "https://www.arm.com/arm-global-web-components/devhub/app.js"

themes/arm-design-system-hugo-theme/layouts/partials/head/head.html

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,9 @@
5555
integrity="sha384-caAG7P/HrHxcdQa2gTEfvZYGPLQk7yRwVdvtRn6sa3TRKzcAyY1LMvObXKGhwFNb"
5656
crossorigin="anonymous">
5757
</script>
58-
<!-- Arm Header & Footer loading. Local development uses the test bundle;
59-
deployment config can explicitly override the stable app.js default. -->
58+
<!-- Arm Header & Footer loading. All environments default to stable app.js;
59+
deployment config can explicitly override the URL for controlled testing. -->
6060
{{ $globalWebComponentsURL := .Site.Params.global_web_components_url | default "https://www.arm.com/arm-global-web-components/devhub/app.js" }}
61-
{{ if and hugo.IsServer (not .Site.Params.global_web_components_url) }}
62-
{{ $globalWebComponentsURL = "https://www.arm.com/arm-global-web-components/devhub/test.js" }}
63-
{{ end }}
6461
<script
6562
type="text/javascript"
6663
src="{{ $globalWebComponentsURL }}"

0 commit comments

Comments
 (0)