From 7f7c26dcedc9626bbcb4db673dad33481771e200 Mon Sep 17 00:00:00 2001 From: armwaheed Date: Tue, 22 Jul 2025 12:26:20 -0500 Subject: [PATCH] Peer review changes --- .../openadkit2_safetyisolation/3_container_spliting.md | 6 +++--- .../openadkit2_safetyisolation/4_multiinstance_executing.md | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/content/learning-paths/automotive/openadkit2_safetyisolation/3_container_spliting.md b/content/learning-paths/automotive/openadkit2_safetyisolation/3_container_spliting.md index 94c5d71714..18e44dc451 100644 --- a/content/learning-paths/automotive/openadkit2_safetyisolation/3_container_spliting.md +++ b/content/learning-paths/automotive/openadkit2_safetyisolation/3_container_spliting.md @@ -55,7 +55,7 @@ To enable ROS 2 and DDS communication between the two nodes, configure network a If you are using AWS EC2, both instances should be assigned to the same Security Group. Within the EC2 Security Group settings: -- Add an inbound rule that allows all traffic from the same Security Group by setting he source to the security group itself. +- Add an inbound rule that allows all traffic from the same Security Group by setting the source to the security group itself. - Outbound traffic is typically allowed by default and usually does not require changes. ![img2 alt-text#center](security_group.jpg "Figure 2: AWS Security Group Setting") @@ -185,7 +185,7 @@ To ensure that each container uses your custom DDS configuration, mount the curr Add this to every container definition to ensure consistent behavior across the deployment. -Here is the complete XML file: +Here is the complete YAML file: ```YAML services: @@ -353,7 +353,7 @@ export TIMEOUT=300 docker compose -f docker-compose-2ins.yml run --rm simulator bash ``` -Once inside the container shell, activate the ROS 2 environment and start publishing to the /hello topic: +Once inside the container shell, activate the ROS 2 environment and start listening to the /hello topic: ```bash # Inside the container: diff --git a/content/learning-paths/automotive/openadkit2_safetyisolation/4_multiinstance_executing.md b/content/learning-paths/automotive/openadkit2_safetyisolation/4_multiinstance_executing.md index 12d69659c5..def332f4e9 100644 --- a/content/learning-paths/automotive/openadkit2_safetyisolation/4_multiinstance_executing.md +++ b/content/learning-paths/automotive/openadkit2_safetyisolation/4_multiinstance_executing.md @@ -27,8 +27,8 @@ On each instance, copy the appropriate launch script into the `openadkit_demo.au !/bin/bash # Configure the environment variables export SCRIPT_DIR=/home/ubuntu/openadkit_demo.autoware/docker - CONF_FILE_PASS=$SCRIPT_DIR/etc/simulation/config/pass_static_obstacle_avoidance.param.yaml - CONF_FILE_FAIL=$SCRIPT_DIR/etc/simulation/config/fail_static_obstacle_avoidance.param.yaml + export CONF_FILE_PASS=$SCRIPT_DIR/etc/simulation/config/pass_static_obstacle_avoidance.param.yaml + export CONF_FILE_FAIL=$SCRIPT_DIR/etc/simulation/config/fail_static_obstacle_avoidance.param.yaml export CONF_FILE=$CONF_FILE_FAIL export COMMON_FILE=$SCRIPT_DIR/etc/simulation/config/common.param.yaml @@ -42,7 +42,7 @@ On each instance, copy the appropriate launch script into the `openadkit_demo.au {{< tab header="Visualizer & Simulator" language="bash">}} #!/bin/bash - SCRIPT_DIR=/home/ubuntu/openadkit_demo.autoware/docker + export SCRIPT_DIR=/home/ubuntu/openadkit_demo.autoware/docker export CONF_FILE_FAIL=$SCRIPT_DIR/etc/simulation/config/fail_static_obstacle_avoidance.param.yaml export CONF_FILE=$CONF_FILE_FAIL