Skip to content

Peer review changes #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pareenaverma merged 1 commit into from
Jul 22, 2025
Merged

Peer review changes #2163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...nt/learning-paths/automotive/openadkit2_safetyisolation/3_container_spliting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ To enable ROS 2 and DDS communication between the two nodes, configure network a
If you are using AWS EC2, both instances should be assigned to the same Security Group.

Within the EC2 Security Group settings:
- Add an inbound rule that allows all traffic from the same Security Group by setting he source to the security group itself.
- Add an inbound rule that allows all traffic from the same Security Group by setting the source to the security group itself.
- Outbound traffic is typically allowed by default and usually does not require changes.

![img2 alt-text#center](security_group.jpg "Figure 2: AWS Security Group Setting")
Expand Down Expand Up @@ -185,7 +185,7 @@ To ensure that each container uses your custom DDS configuration, mount the curr

Add this to every container definition to ensure consistent behavior across the deployment.

Here is the complete XML file:
Here is the complete YAML file:

```YAML
services:
Expand Down Expand Up @@ -353,7 +353,7 @@ export TIMEOUT=300
docker compose -f docker-compose-2ins.yml run --rm simulator bash
```

Once inside the container shell, activate the ROS 2 environment and start publishing to the /hello topic:
Once inside the container shell, activate the ROS 2 environment and start listening to the /hello topic:

```bash
# Inside the container:
Expand Down
6 changes: 3 additions & 3 deletions ...arning-paths/automotive/openadkit2_safetyisolation/4_multiinstance_executing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ On each instance, copy the appropriate launch script into the `openadkit_demo.au
!/bin/bash
# Configure the environment variables
export SCRIPT_DIR=/home/ubuntu/openadkit_demo.autoware/docker
CONF_FILE_PASS=$SCRIPT_DIR/etc/simulation/config/pass_static_obstacle_avoidance.param.yaml
CONF_FILE_FAIL=$SCRIPT_DIR/etc/simulation/config/fail_static_obstacle_avoidance.param.yaml
export CONF_FILE_PASS=$SCRIPT_DIR/etc/simulation/config/pass_static_obstacle_avoidance.param.yaml
export CONF_FILE_FAIL=$SCRIPT_DIR/etc/simulation/config/fail_static_obstacle_avoidance.param.yaml

export CONF_FILE=$CONF_FILE_FAIL
export COMMON_FILE=$SCRIPT_DIR/etc/simulation/config/common.param.yaml
Expand All @@ -42,7 +42,7 @@ On each instance, copy the appropriate launch script into the `openadkit_demo.au

{{< tab header="Visualizer & Simulator" language="bash">}}
#!/bin/bash
SCRIPT_DIR=/home/ubuntu/openadkit_demo.autoware/docker
export SCRIPT_DIR=/home/ubuntu/openadkit_demo.autoware/docker

export CONF_FILE_FAIL=$SCRIPT_DIR/etc/simulation/config/fail_static_obstacle_avoidance.param.yaml
export CONF_FILE=$CONF_FILE_FAIL
Expand Down
Loading