update

Author: ArnavBalyan

parquet-cli/README.md

@@ -136,23 +136,15 @@ Usage: parquet [options] [command] [command options]
 
 ### Configuration Options
 
-The `convert` and `convert-csv` commands support a generic configuration mechanism:
-
 - `--conf` or `--property`: Set any configuration property in format `key=value`. Can be specified multiple times.
 
-This allows you to configure any Avro or Parquet setting without needing to modify source code or rebuild the project.
-
 Examples:
 ```bash
-# Enable UUID support
 parquet convert input.avro -o output.parquet --conf parquet.avro.write-parquet-uuid=true
 
-# Use new 3-level list structure
 parquet convert input.avro -o output.parquet --conf parquet.avro.write-old-list-structure=false
 
-# Convert CSV with multiple options
+# Multiple options
 parquet convert-csv input.csv -o output.parquet --schema schema.avsc --conf parquet.avro.write-parquet-uuid=true --conf parquet.avro.write-old-list-structure=false
 
-# Set any other configuration properties
-parquet convert input.avro -o output.parquet --conf parquet.avro.add-list-element-records=false --conf parquet.avro.write.data.supplier=org.apache.parquet.avro.GenericDataSupplier
 ```

parquet-cli/src/main/java/org/apache/parquet/cli/commands/ConvertCSVCommand.java

@@ -174,10 +174,8 @@ public int run() throws IOException {
       }
     }
 
-    // Create a configuration and apply custom properties
     Configuration conf = new Configuration(getConf());
 
-    // Apply custom configuration properties
     if (confProperties != null) {
       for (String prop : confProperties) {
         String[] parts = prop.split("=", 2);

parquet-cli/src/main/java/org/apache/parquet/cli/commands/ConvertCommand.java

@@ -34,6 +34,7 @@
 import java.util.List;
 import org.apache.avro.Schema;
 import org.apache.avro.generic.GenericData;
+import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.Path;
 import org.apache.parquet.avro.AvroParquetWriter;
@@ -43,7 +44,6 @@
 import org.apache.parquet.hadoop.ParquetWriter;
 import org.apache.parquet.hadoop.metadata.CompressionCodecName;
 import org.slf4j.Logger;
-import org.apache.hadoop.conf.Configuration;
 
 @Parameters(commandDescription = "Create a Parquet file from a data file")
 public class ConvertCommand extends BaseCommand {
@@ -125,10 +125,8 @@ public int run() throws IOException {
       outFS.delete(outPath);
     }
 
-    // Create a configuration and apply custom properties
     Configuration conf = new Configuration(getConf());
 
-    // Apply custom configuration properties
     if (confProperties != null) {
       for (String prop : confProperties) {
         String[] parts = prop.split("=", 2);

parquet-cli/src/test/java/org/apache/parquet/cli/commands/ConvertCSVCommandTest.java

@@ -69,10 +69,8 @@ public void testConvertCSVCommandWithGenericConf() throws IOException {
     command.targets = Arrays.asList(file.getAbsolutePath());
     File output = new File(getTempFolder(), getClass().getSimpleName() + "_with_generic_conf.parquet");
     command.outputPath = output.getAbsolutePath();
-    command.confProperties = Arrays.asList(
-        "parquet.avro.write-parquet-uuid=true",
-        "parquet.avro.write-old-list-structure=false"
-    );
+    command.confProperties =
+        Arrays.asList("parquet.avro.write-parquet-uuid=true", "parquet.avro.write-old-list-structure=false");
     command.setConf(new Configuration());
     Assert.assertEquals(0, command.run());
     Assert.assertTrue(output.exists());

parquet-cli/src/test/java/org/apache/parquet/cli/commands/ConvertCommandTest.java

@@ -48,8 +48,7 @@ public void testConvertCommandWithGenericConf() throws IOException {
     command.confProperties = Arrays.asList(
         "parquet.avro.write-parquet-uuid=true",
         "parquet.avro.write-old-list-structure=false",
-        "test.property=test.value"
-    );
+        "test.property=test.value");
     command.setConf(new Configuration());
 
     Assert.assertEquals(0, command.run());
@@ -64,10 +63,8 @@ public void testConvertCommandConfigurationValidation() throws IOException {
     File output = new File(getTempFolder(), "converted_with_config_validation.parquet");
     command.outputPath = output.getAbsolutePath();
 
-    command.confProperties = Arrays.asList(
-        "parquet.avro.write-parquet-uuid=true",
-        "parquet.avro.write-old-list-structure=false"
-    );
+    command.confProperties =
+        Arrays.asList("parquet.avro.write-parquet-uuid=true", "parquet.avro.write-old-list-structure=false");
 
     command.setConf(new Configuration());
 
@@ -76,10 +73,8 @@ public void testConvertCommandConfigurationValidation() throws IOException {
 
     File output2 = new File(getTempFolder(), "converted_with_config_validation2.parquet");
     command.outputPath = output2.getAbsolutePath();
-    command.confProperties = Arrays.asList(
-        "parquet.avro.write-parquet-uuid=false",
-        "parquet.avro.write-old-list-structure=true"
-    );
+    command.confProperties =
+        Arrays.asList("parquet.avro.write-parquet-uuid=false", "parquet.avro.write-old-list-structure=true");
 
     Assert.assertEquals(0, command.run());
     Assert.assertTrue(output2.exists());