Add a couple additional tests

Author: ArrayBolt3

usr/lib/python3/dist-packages/privleap/tests/run_test.py

@@ -3328,6 +3328,51 @@ def privleapd_invalid_ascii_test(idx_str: str) -> bool:
     return False
 
 
+def privleapd_control_msg_mismatch_test(bogus: str) -> bool:
+    """
+    Test how privleapd handles receiving a comm message on the control socket.
+    """
+
+    if bogus != "":
+        return False
+    discard_privleapd_stderr()
+    control_session: PrivleapSession = PrivleapSession(is_control_session=True)
+    assert control_session.backend_socket is not None
+    # pylint: disable=protected-access
+    # Same rationale as for leaprun_server_invalid_msg_seq_test
+    control_session._PrivleapSession__send_msg(  # type: ignore [attr-defined]
+        PrivleapCommClientSignalMsg("test-act-free")
+    )
+    control_session.close_session()
+    if not compare_privleapd_stderr(
+        PlTestData.privleapd_control_msg_mismatch_lines
+    ):
+        return False
+    return True
+
+
+def privleapd_comm_msg_mismatch_test(bogus: str) -> bool:
+    """
+    Test how privleapd handles receiving a control message on the comm socket.
+    """
+
+    if bogus != "":
+        return False
+    comm_session: PrivleapSession = PrivleapSession("privleaptestone")
+    assert comm_session.backend_socket is not None
+    # pylint: disable=protected-access
+    # Same rationale as for privleapd_control_msg_mismatch_test
+    comm_session._PrivleapSession__send_msg(  # type: ignore [attr-defined]
+        PrivleapControlClientCreateMsg("wha")
+    )
+    comm_session.close_session()
+    if not compare_privleapd_stderr(
+        PlTestData.privleapd_comm_msg_mismatch_lines
+    ):
+        return False
+    return True
+
+
 def privleapd_send_random_garbage_test(bogus: str) -> bool:
     """
     Test how privleapd handles a comm client that sends pseudorandom data.
@@ -4123,6 +4168,18 @@ def run_privleapd_tests() -> None:
             f"Test privleapd invalid ASCII handling (iteration {i+1})",
         )
     # ---
+    privleapd_assert_function(
+        privleapd_control_msg_mismatch_test,
+        "",
+        "Test privleapd control message mismatch handling",
+    )
+    # ---
+    privleapd_assert_function(
+        privleapd_comm_msg_mismatch_test,
+        "",
+        "Test privleapd comm message mismatch handling",
+    )
+    # ---
     privleapd_assert_command(["/usr/bin/privleapd", "-C"], exit_code=0)
     # ---
     privleapd_assert_command(

usr/lib/python3/dist-packages/privleap/tests/run_test_util.py

@@ -1525,3 +1525,14 @@ class PlTestData:
             + "by account 'XXX_USERNAME_XXX' completed",
         ]
     )
+    privleapd_control_msg_mismatch_lines: list[str] = [
+        "handle_control_session: ERROR: Could not get message from control client!\n",
+        "Traceback (most recent call last):\n",
+        "ValueError: Invalid message type 'SIGNAL' for socket\n",
+    ]
+    privleapd_comm_msg_mismatch_lines: list[str] = [
+        "get_client_initial_msg: ERROR: Could not get message from client run by account "
+        + "'privleaptestone'!\n",
+        "Traceback (most recent call last):\n",
+        "ValueError: Invalid message type 'CREATE' for socket\n",
+    ]