Helm: configurable controller Service type and external Postgres password via secret#1079
Open
youknowforsearch wants to merge 1 commit into
Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…word helper - Split Service from controller.yaml into dedicated service.yaml with configurable type, annotations, LBIP, and LBSourceRanges - Add optional Ingress template for HTTP API exposure - Add optional HTTPRoute (Gateway API v1) template - Add optional PodDisruptionBudget for controller - DRY up database password env injection via arroyo.databasePasswordEnv helper - Add init container resource requests/limits - Add per-component nodeSelector/tolerations/affinity (controller.*) - Fix serviceAccountName in worker config (use helper, not raw value) - Clean up _helpers.tpl (remove orphaned junk comments, dead prometheusEndpoint) - Remove unused controllerResources value - Update NOTES.txt for LoadBalancer/Ingress access instructions
youknowforsearch
force-pushed
the
helm-service-type-and-pg-secret
branch
from
June 25, 2026 09:53
6840640 to
e7deb06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes two improvements to the
k8s/arroyoHelm chart:Servicewas hardcoded to the defaultClusterIP, so there was no way to expose Arroyo externally on clusters that rely on cloud load balancers without manually creating aService. This adds:controller.service.type(defaults toClusterIP) — set toLoadBalancerorNodePortcontroller.service.annotations— e.g. cloud LB annotationscontroller.service.loadBalancerIPandcontroller.service.loadBalancerSourceRanges(only applied forLoadBalancer)postgresql.externalDatabase.existingSecretandpostgresql.externalDatabase.existingSecretPasswordKey. When set, the password is injected into the controller pods via asecretKeyRef(both the migrate init container and the controller container) and is no longer written to the ConfigMap.All changes are backward compatible: the defaults preserve the existing behavior (
ClusterIPservice, in-cluster Postgres, or plaintext external password when no secret is provided).Test plan
helm lintpasseshelm templaterenders correctly for: external DB +existingSecret(no plaintext password in ConfigMap,secretKeyRefenv in both containers)postgresql.deploy=true(serviceClusterIP, password from the deployed Postgres secret)LoadBalancerservice renderstype,annotations,loadBalancerIP, andloadBalancerSourceRangesMade with Cursor