Revert pdb load simplification

Arthri · Arthri · commit 9891d00ae673 · 2023-06-15T12:08:16.000Z
diff --git a/TerrariaServerAPI/TerrariaApi.Server/ServerApi.cs b/TerrariaServerAPI/TerrariaApi.Server/ServerApi.cs
@@ -350,8 +350,9 @@ internal static void LoadPlugins()
 						byte[] pe = null;
 						try
 						{
-							var pdbPath = Path.ChangeExtension(fileInfo.FullName, ".pdb");
-							assembly = Assembly.Load(pe = File.ReadAllBytes(fileInfo.FullName), File.Exists(pdbPath) ? File.ReadAllBytes(pdbPath) : null);
+							var pdb = Path.ChangeExtension(fileInfo.FullName, ".pdb");
+							var symbols = File.Exists(pdb) ? File.ReadAllBytes(pdb) : null;
+							assembly = Assembly.Load(pe = File.ReadAllBytes(fileInfo.FullName), symbols);
 						}
 						catch (BadImageFormatException)
 						{

Original file line number	Diff line number	Diff line change
`@@ -350,8 +350,9 @@ internal static void LoadPlugins()`
`350`	`350`	`byte[] pe = null;`
`351`	`351`	`try`
`352`	`352`	`{`
`353`		`- var pdbPath = Path.ChangeExtension(fileInfo.FullName, ".pdb");`
`354`		`- assembly = Assembly.Load(pe = File.ReadAllBytes(fileInfo.FullName), File.Exists(pdbPath) ? File.ReadAllBytes(pdbPath) : null);`
	`353`	`+ var pdb = Path.ChangeExtension(fileInfo.FullName, ".pdb");`
	`354`	`+ var symbols = File.Exists(pdb) ? File.ReadAllBytes(pdb) : null;`
	`355`	`+ assembly = Assembly.Load(pe = File.ReadAllBytes(fileInfo.FullName), symbols);`
`355`	`356`	`}`
`356`	`357`	`catch (BadImageFormatException)`
`357`	`358`	`{`