Skip to content

Commit 2726e5e

Browse files
committed
use thread pool executors for async image loading and cropping operations to prevent app hang if default executor is busy (thx @ruifcardoso)
1 parent ff42443 commit 2726e5e

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ For more information, see the [GitHub Wiki](https://github.com/ArthurHub/Android
123123
## Change log
124124
*2.5.1* (in-dev)
125125
- Try solve manifest merger issue by adding `transitive` flag #405 (thx @j-garin)
126+
- Use thread pool executors for async image loading and cropping operations to prevent app hang if default executor is busy (thx @ruifcardoso)
126127

127128
*2.5.0*
128129
- Update to sdk v26

cropper/src/main/java/com/theartofdev/edmodo/cropper/CropImageView.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import android.graphics.Rect;
2323
import android.graphics.RectF;
2424
import android.net.Uri;
25+
import android.os.AsyncTask;
2526
import android.os.Bundle;
2627
import android.os.Parcelable;
2728
import android.support.media.ExifInterface;
@@ -1020,7 +1021,7 @@ public void setImageUriAsync(Uri uri) {
10201021
mRestoreDegreesRotated = 0;
10211022
mCropOverlayView.setInitialCropWindowRect(null);
10221023
mBitmapLoadingWorkerTask = new WeakReference<>(new BitmapLoadingWorkerTask(this, uri));
1023-
mBitmapLoadingWorkerTask.get().execute();
1024+
mBitmapLoadingWorkerTask.get().executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
10241025
setProgressBarVisibility();
10251026
}
10261027
}
@@ -1318,7 +1319,7 @@ public void startCropWorkerTask(
13181319
saveCompressFormat,
13191320
saveCompressQuality));
13201321
}
1321-
mBitmapCroppingWorkerTask.get().execute();
1322+
mBitmapCroppingWorkerTask.get().executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
13221323
setProgressBarVisibility();
13231324
}
13241325
}

0 commit comments

Comments
 (0)