Use CharSequence instead of string for activity title (#297)

Author: ArthurHub

README.md

@@ -123,6 +123,7 @@ For more information, see the [GitHub Wiki](https://github.com/ArthurHub/Android
 ## Change log
 *2.4.7*
 - Fix toolbar menu crop icon sometimes appears with random icon (#305)
+- Use CharSequence instead of string for activity title (thx @KentHawkings) (#297)
 - Fix class not found exception on some Samsung devices (Huge thanks to @Vantablack) (#332)
 - Add original image dimensions to CropResult (Thanks @gazialankus) (#327)
 - Making the library JitPack-friendly (Thanks @gazialankus) (#325)

cropper/src/main/java/com/theartofdev/edmodo/cropper/CropImage.java

@@ -756,7 +756,7 @@ public ActivityBuilder setMaxCropResultSize(int maxCropResultWidth, int maxCropR
          * the title of the {@link CropImageActivity}.<br>
          * <i>Default: ""</i>
          */
-        public ActivityBuilder setActivityTitle(String activityTitle) {
+        public ActivityBuilder setActivityTitle(CharSequence activityTitle) {
             mOptions.activityTitle = activityTitle;
             return this;
         }

cropper/src/main/java/com/theartofdev/edmodo/cropper/CropImageActivity.java

@@ -87,7 +87,7 @@ public void onCreate(Bundle savedInstanceState) {
 
         ActionBar actionBar = getSupportActionBar();
         if (actionBar != null) {
-            String title = mOptions.activityTitle != null && !mOptions.activityTitle.isEmpty()
+            CharSequence title = mOptions.activityTitle != null && mOptions.activityTitle.length() > 0
                     ? mOptions.activityTitle
                     : getResources().getString(R.string.crop_image_activity_title);
             actionBar.setTitle(title);

cropper/src/main/java/com/theartofdev/edmodo/cropper/CropImageOptions.java

@@ -19,6 +19,7 @@
 import android.net.Uri;
 import android.os.Parcel;
 import android.os.Parcelable;
+import android.text.TextUtils;
 import android.util.DisplayMetrics;
 import android.util.TypedValue;
 
@@ -87,10 +88,10 @@ public CropImageOptions[] newArray(int size) {
      */
     public boolean autoZoomEnabled;
 
-  /**
-   * if multi-touch should be enabled on the crop box
-   * default: false
-   */
+    /**
+     * if multi-touch should be enabled on the crop box
+     * default: false
+     */
     public boolean multiTouchEnabled;
 
     /**
@@ -196,7 +197,7 @@ public CropImageOptions[] newArray(int size) {
     /**
      * the title of the {@link CropImageActivity}
      */
-    public String activityTitle;
+    public CharSequence activityTitle;
 
     /**
      * the color to use for action bar items icons
@@ -373,7 +374,7 @@ protected CropImageOptions(Parcel in) {
         minCropResultHeight = in.readInt();
         maxCropResultWidth = in.readInt();
         maxCropResultHeight = in.readInt();
-        activityTitle = in.readString();
+        activityTitle = TextUtils.CHAR_SEQUENCE_CREATOR.createFromParcel(in);
         activityMenuIconColor = in.readInt();
         outputUri = in.readParcelable(Uri.class.getClassLoader());
         outputCompressFormat = Bitmap.CompressFormat.valueOf(in.readString());
@@ -423,7 +424,7 @@ public void writeToParcel(Parcel dest, int flags) {
         dest.writeInt(minCropResultHeight);
         dest.writeInt(maxCropResultWidth);
         dest.writeInt(maxCropResultHeight);
-        dest.writeString(activityTitle);
+        TextUtils.writeToParcel(activityTitle, dest, flags);
         dest.writeInt(activityMenuIconColor);
         dest.writeParcelable(outputUri, flags);
         dest.writeString(outputCompressFormat.name());

quick-start/src/main/java/com/theartofdev/edmodo/cropper/quick/start/MainActivity.java

@@ -36,7 +36,7 @@ protected void onCreate(Bundle savedInstanceState) {
     public void onSelectImageClick(View view) {
         CropImage.activity()
                 .setGuidelines(CropImageView.Guidelines.ON)
-                .setMultiTouchEnabled(true)
+                .setActivityTitle("My Crop")
                 .start(this);
     }