Merge pull request #32 from AsBuiltReport/dev

v0.4.7 public release

Author: rebelinux

.github/workflows/Release.yml

@@ -21,19 +21,19 @@ jobs:
         shell: pwsh
         run: |
           Publish-Module -Path ./ -NuGetApiKey ${{ secrets.PSGALLERY_API_KEY }} -Verbose
-  tweet:
-    needs: publish-to-gallery
-    runs-on: ubuntu-latest
-    steps:
-      - uses: Eomm/why-don-t-you-tweet@v2
-        # We don't want to tweet if the repository is not a public one
-        if: ${{ !github.event.repository.private }}
-        with:
-          # GitHub event payload
-          # https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#release
-          tweet-message: "[New Release] ${{ github.event.repository.name }} ${{ github.event.release.tag_name }}! Check out what's new! ${{ github.event.release.html_url }} #VMware #SRM #vExpert #AsBuiltReport #PowerShell"
-        env:
-          TWITTER_CONSUMER_API_KEY: ${{ secrets.TWITTER_CONSUMER_API_KEY }}
-          TWITTER_CONSUMER_API_SECRET: ${{ secrets.TWITTER_CONSUMER_API_SECRET }}
-          TWITTER_ACCESS_TOKEN: ${{ secrets.TWITTER_ACCESS_TOKEN }}
-          TWITTER_ACCESS_TOKEN_SECRET: ${{ secrets.TWITTER_ACCESS_TOKEN_SECRET }}
+  # tweet:
+  #   needs: publish-to-gallery
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - uses: Eomm/why-don-t-you-tweet@v2
+  #       # We don't want to tweet if the repository is not a public one
+  #       if: ${{ !github.event.repository.private }}
+  #       with:
+  #         # GitHub event payload
+  #         # https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#release
+  #         tweet-message: "[New Release] ${{ github.event.repository.name }} ${{ github.event.release.tag_name }}! Check out what's new! ${{ github.event.release.html_url }} #VMware #SRM #vExpert #AsBuiltReport #PowerShell"
+  #       env:
+  #         TWITTER_CONSUMER_API_KEY: ${{ secrets.TWITTER_CONSUMER_API_KEY }}
+  #         TWITTER_CONSUMER_API_SECRET: ${{ secrets.TWITTER_CONSUMER_API_SECRET }}
+  #         TWITTER_ACCESS_TOKEN: ${{ secrets.TWITTER_ACCESS_TOKEN }}
+  #         TWITTER_ACCESS_TOKEN_SECRET: ${{ secrets.TWITTER_ACCESS_TOKEN_SECRET }}

AsBuiltReport.VMware.SRM.psd1

@@ -12,7 +12,7 @@
 RootModule = 'AsBuiltReport.VMware.SRM.psm1'
 
 # Version number of this module.
-ModuleVersion = '0.4.6'
+ModuleVersion = '0.4.7'
 
 # Supported PSEditions
 # CompatiblePSEditions = @()
@@ -27,7 +27,7 @@ Author = 'Jonathan Colon'
 # CompanyName = 'ZenPrSolutions'
 
 # Copyright statement for this module
-Copyright = '(c) 2023 Jonathan Colon. All rights reserved.'
+Copyright = '(c) 2024 Jonathan Colon. All rights reserved.'
 
 # Description of the functionality provided by this module
 Description = 'A PowerShell module to generate an as built report on the configuration of VMware SRM.'

CHANGELOG.md

@@ -1,5 +1,11 @@
 # :arrows_clockwise: VMware SRM As Built Report Changelog
 
+## [0.4.7] - 2024-11-07
+
+### Fixed
+
+- Fix empty value bug
+
 ## [0.4.6] - 2024-11-04
 
 ### Changed

Src/Private/Get-AbrSRMNetworkMapping.ps1

@@ -35,7 +35,7 @@ function Get-AbrSRMNetworkMapping {
                 }
 
                 if ($LocalNetworkMappings) {
-                    Section -Style NOTOCHeading3 -ExcludeFromTOC $($ProtectedSiteName) {
+                    Section -Style Heading3 -ExcludeFromTOC $($ProtectedSiteName) {
                         $OutObj = @()
                         foreach ($ObjMap in $LocalNetworkMappings) {
                             $inObj = [Ordered]@{
@@ -67,7 +67,7 @@ function Get-AbrSRMNetworkMapping {
                 }
 
                 if ($RemoteNetworkMappings) {
-                    Section -Style NOTOCHeading3 -ExcludeFromTOC $($RecoverySiteName) {
+                    Section -Style Heading3 -ExcludeFromTOC $($RecoverySiteName) {
                         $OutObj = @()
                         foreach ($ObjMap in $RemoteNetworkMappings) {
                             $inObj = [Ordered]@{

Src/Private/Get-AbrSRMPermission.ps1

@@ -35,7 +35,7 @@ function Get-AbrSRMPermission {
                 BlankLine
 
                 if ($LocalVIPermissions) {
-                    Section -Style NOTOCHeading3 -ExcludeFromTOC $($ProtectedSiteName) {
+                    Section -Style Heading3 -ExcludeFromTOC $($ProtectedSiteName) {
                         $OutObj = @()
                         foreach ($LocalVIPermission in $LocalVIPermissions) {
                             Write-PScriboMessage "Discovered SRM Permissions $($LocalVIPermission.Name)."
@@ -63,7 +63,7 @@ function Get-AbrSRMPermission {
                 }
 
                 if ($RemoteVIPermissions) {
-                    Section -Style NOTOCHeading3 -ExcludeFromTOC $($RecoverySiteName) {
+                    Section -Style Heading3 -ExcludeFromTOC $($RecoverySiteName) {
                         $OutObj = @()
                         foreach ($RemoteVIPermission in $RemoteVIPermissions) {
                             Write-PScriboMessage "Discovered SRM Permissions $($RemoteVIPermission.Name)."

Src/Private/SharedUtilsFunctions.ps1

@@ -145,7 +145,7 @@ function ConvertTo-HashToYN {
         try {
             $result.add($i.Key, (ConvertTo-TextYN $i.Value))
         } catch {
-            Write-PScriboMessage -IsWarning "Unable to process $($i.key) values"
+            $result.add($i.Key, ($i.Value))
         }
     }
     if ($result) {