fix: resolve multiple issues across Day 1, 2, 8, 14, 18, 22#810
Open
harshc01 wants to merge 6 commits intoAsabeneh:masterfrom
Open
fix: resolve multiple issues across Day 1, 2, 8, 14, 18, 22#810harshc01 wants to merge 6 commits intoAsabeneh:masterfrom
harshc01 wants to merge 6 commits intoAsabeneh:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I went through some of the open issues and fixed a bunch of them in one go. Here's what I changed:
#807 + #758 — Day 1: Wrong comment on set/tuple (helloworld.py)
{9.8, 3.14, 2.7}is a set, curly braces give you a set not a tuple. The comment said# Tuplewhich is wrong and would confuse beginners. Fixed the comment and also added the actual tuple example with parentheses so both are shown side by side.#808 — Day 14: That exercise question is JavaScript, not Python
Question 8 in Level 2 had
arr.map(callback).filter(callback).reduce(callback)— that's JS method chaining. Python doesn't work like that, map/filter/reduce are standalone functions. I have replaced it with a proper Python description.#775 + #792 — Day 2:
int('10.6')crashes with ValueErrorThe example tried to do
int(num_str)directly on'10.6'which just throws a ValueError. Also had the same variable assigned twice for no reason andint(num_int)on something that was already an int. Cleaned the whole thing up.#760 — Day 22: Broken URL in exercise
The BU facts page link was using
http://and returning a 404. Just changed it tohttps://, the page is still up.#749 — Day 18:
re.matchin the search syntax exampleThe syntax section for
re.searchwas showingre.match(...)instead. Simple!#731 — Day 8: Dictionaries are not "unordered" anymore
Calling dicts unordered is only true for Python 3.6 and below. Since 3.7 they maintain insertion order. Updated the definition to reflect that — also avoided just saying "ordered" since that implies sorting which isn't the case.
#721 — Day 8:
is_marredtypoThe person dictionary had
is_marredinstead ofis_marriedin 6 different places, which also broke some of the code examples further down. I have fixed all of them.