Commit 062fab2
Merge upstream LeanType v3.8.6 (handwriting, llama.cpp/GGUF, touchpad gestures) (#109)
* fix(settings): fix and optimize gboard import
Parse Gboard format header dynamically to fix missing words and swapped values. Optimize using bulkInsert to reduce database insertion IPC overhead.
* chore: bump version to 3.8.4
Set versionCode to 3840 and versionName to 3.8.4 in build.gradle.kts. Create Fastlane changelog metadata at 3840.txt.
* feat(settings): improve text expander ui/ux
Add responsive search filtering for text expansion shortcuts. Add quick placeholder selection row with rich cursor-based insert support to Add/Edit Dialog.
* feat(settings): polish text expander guide and list
Redesign Quick Feature Guide card with styled step badges. Redesign custom shortcuts list items with premium keyword badges and chevrons. Redesign empty state with card illustration layout.
* feat(settings): clean up text expander guide
Remove redundant template placeholder explanation while retaining the list of supported placeholder tags.
* feat(settings): add more expander placeholders
Add support and UI representations for %month%, %month_short%, %year%, and %week% placeholders.
* feat(settings): add system template placeholders
Add and integrate support for %battery%, %device%, and %android% placeholders.
* feat(settings): add language placeholder
Add and integrate support for %language% placeholder, which expands to the current active keyboard display language.
* fix(perf): prevent OOM on background image decode
- Add BitmapUtils.decodeSampledBitmap() with two-pass decode and inSampleSize
- Use RGB_565 config for non-PNG images to halve memory usage
- Use BitmapFactory.decodeStream (with InputStream) instead of decodeFile
- Cap background bitmap at 2048px max dimension
- Recycle temp bitmap after validation in setBackgroundImage
Fixes: Settings.java:527, BackgroundImagePreference.kt:122
* fix(stability): replace force-unwrap !! in hot paths
- Colors.kt: use 'let' smart cast and 'error' instead of NPE on missing keyBackground
- FloatingKeyboardManager.kt: safe-call on overlayRoot, early return on null
- SuggestionStripView.kt: early return true on missing drawable
Prevents IME process crashes from null drawables/bitmaps in keyboard rendering paths.
* fix(stability): unregister SharedPreferences listener in spell-checker
AndroidSpellCheckerService.onDestroy() now unregisters the
OnSharedPreferenceChangeListener. Without this, the SharedPreferences
implementation kept a strong reference to the service, leaking it
through every spell-check session the system bound/unbound.
* fix(stability): don't call Looper.prepare() on background thread
BackupRestorePreference.kt was calling Looper.prepare() from the
ScheduledThreadPool executor, leaking a Looper per restore and posting
UI work onto an unreliable thread. Use Handler(Looper.getMainLooper())
to dispatch the FeedbackManager.message call to the UI thread.
* fix(stability): make score-limit cache update atomic in Suggest
The previous implementation had a non-atomic read-then-write of
mLastScoreLimitUpdateTime and mCachedScoreLimitForAutocorrect across
threads (suggestion lookup can happen on background threads via
SuggestionSpan / TextClassifier). Two threads could both miss the
interval check and recompute, with the second write overwriting the
first. Wrap the cache update in synchronized(this) to make the check
and update atomic.
* fix(stability): use named lock for dictionary blacklist
Three blacklist operations in DictionaryGroup used
`<outer>.apply { scope.launch { synchronized(this) { ... } } }`,
which re-bound `this` to the HashSet / CoroutineScope inside the
synchronized block. Two threads could enter the critical section
concurrently because they were locking on different objects.
Add an explicit `blacklistLock: Any` and synchronize on it.
* perf(perf): add key= to Lazy* list items for stable identity
- SearchScreen: key groups by titleRes, items by toString()
- ListPickerDialog, MultiListPickerDialog: key items by toString()
- LayoutPickerDialog: key by layout name
- ToolbarKeysCustomizer: key by enum name
- ColorThemePickerDialog: key by color name
Without keys, LazyColumn uses positional keys, causing every visible
item to be recomposed (and its remember slots discarded) on every
search keystroke or list mutation.
* perf(perf): remember() expensive computations in Composables
- SearchScreen: cache filteredItems(searchText.text) so it doesn't
re-run the search filter on every parent recomposition (only when
the search text actually changes)
- MainSettingsScreen: cache SubtypeSettings.getEnabledSubtypes() and
its joinToString() output so the description string is not rebuilt
on every recomposition
Both lists are otherwise recomputed on every pref change, every
parent state change, and every scroll-induced recomposition.
* perf(perf): avoid Paint allocation per recomposition in ColorPickerDialog
Wrap the Paint in remember { } and assign to the controller inside a
LaunchedEffect so the Paint is created once and not allocated on every
recomposition. Also avoids re-assigning the controller's wheelPaint
on every recomposition.
* perf(perf): stream logcat to file instead of buffering in memory
AboutScreen's 'Save log' was reading the entire logcat buffer into a
single String via readText(), then writing it out. For a long-running
device this can be several MB and compete with the IME process for
memory, risking OOM on low-RAM devices.
Use useLines { } to iterate line by line and write each one
directly to the output stream. The internal log is now also
streamed with a for loop and explicit toString() instead of a
joinToString() that builds the entire list as a single String.
* perf(perf): make ReorderSwitchPreference data class stable
The private KeyAndState class had var fields that were mutated in the
Switch.onCheckedChange callback, defeating Compose stability and
forcing LazyColumn items to be rebuilt on every recomposition.
- Make KeyAndState an immutable data class annotated with @immutable
- Hold the checked state in rememberSaveable(item.name) so the value
survives recomposition but is per-item
- Remove the in-place mutation of item.state in the Switch callback
- rememberSaveable the items list so it's not re-parsed on every
recomposition when the dialog is open
* fix(perf): remove top-level MutableStateFlow in AIIntegrationScreen
The previous top-level 'providerState' MutableStateFlow lived for the
process lifetime and was mutated during composition. The state can
be derived from the service on every composition (the service reads
from SharedPreferences, which is cheap).
- Replace top-level MutableStateFlow with a simple val read
- Remove the no-op updateProviderState() function
- Remove its call site in AdvancedScreen.kt
The AIIntegrationScreen will pick up provider changes on the next
composition (e.g. when the user navigates to it after changing the
provider on the AdvancedScreen).
* fix(perf): scope errorJob to the LayoutEditDialog composable
The top-level 'private var errorJob: Job?' was shared between any
two simultaneous instances of LayoutEditDialog, so opening a second
dialog would cancel the first dialog's pending error feedback job.
On configuration change the coroutine scope could be cancelled while
the top-level job reference was leaked.
Move the job into a per-composable remember { mutableStateOf<Job?>(null) }
and cancel/assign through errorJob.value.
* fix(perf): replace GlobalScope in toolbar preference listener
setToolbarButtonsActivatedStateOnPrefChange used GlobalScope.launch to
defer a UI update by 10 ms, waiting for SettingsValues to reload after
a SharedPreferences change. GlobalScope is uncancellable and its
default exception handler converts failures into silent crashes.
Replace it with a process-wide scope that uses SupervisorJob (so one
failure cannot tear down sibling preference updates) and a logging
CoroutineExceptionHandler. The function still hops to Dispatchers.Main
before touching the view tree.
* fix(perf): make SettingsNavHost navigateTo scope supervised
The CoroutineScope backing the navigateTo() helper used a plain Job,
so a single child failure would cancel the scope permanently. Add
SupervisorJob so unrelated navigation hops keep working.
* fix(stability): replace !! in colorFilter() helper
createBlendModeColorFilterCompat returns a nullable ColorFilter, but
the helper is only ever called with the supported BlendModeCompat
modes (MODULATE, SRC_IN). Replace the !! with a Kotlin error() that
throws IllegalStateException with a useful message if a new
unsupported mode is ever introduced.
* perf(perf): cache main-thread Handler in ClipboardHistoryManager
ClipboardHistoryManager is a singleton scoped to the IME service, but
it was creating a fresh Handler(Looper.getMainLooper()) on every
postDelayed() and on every ContentObserver registration. The main
Looper is process-wide and lives for the lifetime of the app, so a
single cached Handler is enough.
Replace the two ad-hoc Handler allocations in registerMediaStoreObserver
and in the post-paste clip restoration path with a single 'mainHandler'
field on the manager.
* fix(stability): use SupervisorJob in RichInputMethodManager scope
The CoroutineScope backing updateShortcutIme, onSubtypeChanged and
related fire-and-forget coroutines was using a plain Job. A single
exception in any of those coroutines would cancel the scope and stop
all subsequent subtype lookups for the lifetime of the IME process.
Add SupervisorJob() so a single failure cannot tear down the rest
of the lookups.
* fix(stability): use ContextCompat.registerReceiver with NOT_EXPORTED flag
LatinIME.onCreate was using the deprecated registerReceiver(receiver,
filter) overload for the ringer mode, package add/remove and user
unlocked broadcasts. On Android 13+ this throws SecurityException
unless the receiver is registered with an explicit exported flag.
Switch the three call sites to ContextCompat.registerReceiver with
RECEIVER_NOT_EXPORTED, matching the existing style used for
DICTIONARY_DUMP_INTENT_ACTION. The exported flag stays set for the
NEW_DICTIONARY_INTENT_ACTION receiver, as documented in the existing
comment, because the sender app may not be this one.
* fix(settings): update ai provider fields dynamically
Align provider preference source and observe changes dynamically to update UI fields immediately. Wrap preferences in key() to prevent Compose state reuse.
* feat: add standardOptimised flavor and disable r8
Add standardOptimised flavor to allow non-reproducible optimizations like R8 fullMode and baseline profiles. Turn off R8 fullMode globally to restore reproducibility for standard flavor on F-Droid. Clean APK metadata and restore global V2/V3 signing.
* perf: add baseline profile for standardOptimised
Add manual wildcard-based precompilation rules in baseline-prof.txt for standardOptimised to optimize startup, typing reaction, and suggestions. Fix dynamic property injection in settings.gradle.
* feat: remove standardOptimised package suffix
Remove applicationIdSuffix from standardOptimised product flavor to share standard package name (com.leanbitlab.leantype).
* fix: dismiss emoji dialog and update wizard status
Close ConfirmationDialog on successful emoji dictionary download/load. Invoke onSuccess callback in WelcomeWizard to trigger recomposition and show the checkmark immediately.
* Update ar.txt
* Update build-debug-apk.yml
* arabic-popup-and-harakat-tweak
* arabic-popup-and-harakat-tweak V2
* ci: add badge update workflow
* chore: update README badges [skip ci]
* fix: strip leading v from version tag
* chore: update README badges [skip ci]
* fix(badges): adjust width and add viewBox attributes to prevent clipping
* chore: update README badges [skip ci]
* chore(badges): rename download badge label to version
* chore: update README badges [skip ci]
* fix: prevent duplicate screenshots in clipboard
* feat: add toggle for screenshot compression
* feat: improve text expander, gestures, and emoji scale fit
* chore: update README badges [skip ci]
* fix: persist toolbar customizer key toggles
* build: bump version to v3.8.5
* feat: toggle dictionaries individually
* chore: add changelog for v3.8.5
* fix: split emoji search keyboard layout
* chore: update changelog for emoji search fix
* added auto detect feature
* changed registration flag
* chore: update README badges [skip ci]
* Update ar.txt
* refactor: replace onnxruntime with llamacpp
Switches offline proofreader to llamacpp-kotlin GGUF and updates model settings UI to resolve 16 KB page alignment compatibility warnings.
* suggestion delete blacklist always. reload blacklist interface add.
* blocked words screen add. dictionary screen integration done. settings strings update.
* blacklist check case-insensitive. lowercase canonicalization added. user dictionary suggestion leak resolved.
* blacklist regex support added. compiled patterns cached. compile-time receiver errors resolved.
* SearchScreen remember key fix. filteredItems lambda dependency added. list auto-refresh working.
* fix(layout): align Arabic diacritics spacing
* chore: update README badges [skip ci]
* chore: update README badges [skip ci]
* chore: update README badges [skip ci]
* chore: update README badges [skip ci]
* chore: update README badges [skip ci]
* Allow for reasoning models; handle structured content arrays in API responses
Parse JSONArray content format with type and text fields. Extract reasoning_content when main content is blank. Fall back to firstChoice text field if content extraction fails.
* feat: add regex expander & fix dictionary crash
* feat(touchpad): double tap to select word & fix emoji popup preview
* feat(offline): add settings for custom sampling & prompt
* chore: update gitignore - add .env, .pi/ and remove duplicate
* docs: add F-Droid reproducibility delay notice
* chore: bump version to v3.8.6 and add changelog
* fix(touchpad): always select word on double tap and update docs
* feat(touchpad): implement multi-finger gestures and update docs
* feat(touchpad): reorganize gestures for intuitive rich text editing layout
* feat(touchpad): migrate gestures to 1 and 2 fingers
* docs: update features for llama.cpp migration
* docs: note model-dependent accuracy in features
* fix(touchpad): exit touchpad mode when opening clipboard or emoji
* perf(offline): optimize proofreading latency and load times
* fix(offline): improve GGUF prompt formatting and output cleaning
* fix(offline): truncate model output at template markers and add native stop sequences
* fix(offline): implement dynamic target-language-specific few-shot examples for GGUF translation
* feat(expander): immediate expand & fix revert
* feat: hold toolbar arrow keys to auto-repeat
* chore: update README badges [skip ci]
* chore: update README badges [skip ci]
* chore: update README badges [skip ci]
* feat: add toggle for insecure AI connections
Allows HTTP local endpoints and self-signed HTTPS connections only when explicitly enabled by the user.
* feat: add selective backup and restore
* fix: allow same word with different shortcuts
* feat: strip spaces before punctuation marks
* chore: update README badges [skip ci]
* chore: update README badges [skip ci]
* chore: update README badges [skip ci]
* chore: update README badges [skip ci]
* Change default popup key on letter ا in Persian language
* chore: update README badges [skip ci]
* feat: add handwriting input support
* docs: update 3.8.6 changelog
* fix: use wildcard mime type for file picker to avoid waydroid crash
* fix: clear code cache directory on plugin import/remove
* chore: add MD5 hash and size logging for loaded plugin
* feat(handwriting): fix crash and dynamic model downloading
Move model readiness checks to background thread to prevent main thread blocking exceptions. Add ML Kit client dependencies to standard build flavor for native library alignment. Auto-upgrade toolbar preferences to discover new keys without factory resets.
* feat: fix handwriting layout, theming and logic
* style: change handwriting toolbar icon color to white
* feat: show shortcut overlay on handwriting canvas when plugin missing
* fix(ai): resolve offline custom key token loss
Prevent token loss and hallucination in local models due to formatting and JNI bugs.
* feat(handwriting): add plugin downloader and refine blacklist
* build: limit abi filters to arm64-v8a
* docs: document handwriting and gguf features
* chore(release): bump to 3.10.0 (4000) + changelog
* fix(handwriting): don't cancel active keys when hiding inactive handwriting
---------
Co-authored-by: LeanBitLab <leanbitlab@users.noreply.github.com>
Co-authored-by: iBasim <57762287+iBasim@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rohan Lodhi <42321434+RohanLodhi@users.noreply.github.com>
Co-authored-by: LeanBitLab <arjunathira2222@gmail.com>
Co-authored-by: David C <code@davidc.xyz>
Co-authored-by: nugraha-abd <62243267+nugraha-abd@users.noreply.github.com>1 parent 8e7621e commit 062fab2
72 files changed
Lines changed: 3627 additions & 717 deletions
File tree
- .github/workflows
- app
- src
- main
- assets
- layouts/handwriting_bottom
- locale_key_texts
- java/helium314/keyboard
- keyboard
- clipboard
- emoji
- internal
- keyboard_parser
- floris
- latin
- handwriting
- inputlogic
- settings
- suggestions
- utils
- settings
- preferences
- screens
- res
- drawable
- layout
- values
- xml
- offlinelite/java/helium314/keyboard/latin/utils
- offline/java/helium314/keyboard/latin/utils
- standard/java/helium314/keyboard/latin/utils
- test/java/helium314/keyboard/latin/handwriting
- docs
- badges
- fastlane/metadata/android/en-US/changelogs
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
17 | 41 | | |
18 | 42 | | |
19 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
| 27 | + | |
27 | 28 | | |
28 | | - | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
41 | | - | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
73 | 74 | | |
74 | 75 | | |
75 | 76 | | |
| 77 | + | |
| 78 | + | |
76 | 79 | | |
77 | 80 | | |
78 | 81 | | |
79 | | - | |
80 | | - | |
81 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
82 | 85 | | |
83 | 86 | | |
84 | | - | |
| 87 | + | |
85 | 88 | | |
86 | 89 | | |
87 | 90 | | |
88 | 91 | | |
89 | | - | |
| 92 | + | |
90 | 93 | | |
91 | 94 | | |
92 | 95 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
| 25 | + | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
37 | 35 | | |
38 | 36 | | |
39 | 37 | | |
| |||
45 | 43 | | |
46 | 44 | | |
47 | 45 | | |
| 46 | + | |
48 | 47 | | |
49 | 48 | | |
50 | 49 | | |
| |||
141 | 140 | | |
142 | 141 | | |
143 | 142 | | |
144 | | - | |
| 143 | + | |
145 | 144 | | |
146 | 145 | | |
147 | 146 | | |
| |||
235 | 234 | | |
236 | 235 | | |
237 | 236 | | |
238 | | - | |
239 | | - | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
240 | 252 | | |
241 | 253 | | |
242 | 254 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | 31 | | |
35 | 32 | | |
36 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| |||
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
| 32 | + | |
| 33 | + | |
30 | 34 | | |
31 | 35 | | |
32 | 36 | | |
| |||
122 | 126 | | |
123 | 127 | | |
124 | 128 | | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
125 | 157 | | |
126 | 158 | | |
127 | 159 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
0 commit comments