fix(toolbar): restore toolbar key icon tint#117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores normal toolbar key icon/background tinting after the upstream v3.9.1 sync.
The sync introduced
toolbar_key_backgroundassignment and long-press hint wrapping increateToolbarKey(), but normal toolbar keys were no longer explicitly tinted after the drawable/background were assigned. State-key backgrounds still worked, but non-state toolbar icons could render with incorrect/default tint.This PR reapplies the normal toolbar colors at key creation:
ColorType.TOOL_BAR_KEYfor the iconColorType.TOOL_BAR_EXPAND_KEY_BACKGROUNDfor the toolbar-key backgroundVerification
./gradlew.bat :app:assembleStandardfullDebug --no-daemon --console=plainpassedBlocker before merge
This is a visual regression fix and is not yet visually verified on device. Wireless adb disconnected before I could install and capture a screenshot.
Before merging:
standardfullDebugAPK on device.Do not merge on build-only evidence.