Node 24 Fibers patch dockerfile updates

Author: JackStrohm-asana

Dockerfile.Fibers

@@ -49,7 +49,22 @@ RUN echo -------------------
 RUN git clone --branch jackstrohm_node20_fibers --depth 1 https://github.com/asana/node-fibers.git node-fibers
 
 WORKDIR /usr/src/node/node-fibers
+
+# Apply V8 v13 API compatibility patches for accessor callbacks
+# Change Local<String> to Local<Name> in getter/setter signatures
+RUN sed -i 's/GetStarted(Local<String> property/GetStarted(Local<Name> property/g' src/fibers.cc && \
+    sed -i 's/GetCurrent(Local<String> property/GetCurrent(Local<Name> property/g' src/fibers.cc && \
+    sed -i 's/GetPoolSize(Local<String> property/GetPoolSize(Local<Name> property/g' src/fibers.cc && \
+    sed -i 's/SetPoolSize(Local<String> property/SetPoolSize(Local<Name> property/g' src/fibers.cc && \
+    sed -i 's/GetFibersCreated(Local<String> property/GetFibersCreated(Local<Name> property/g' src/fibers.cc
+
+# Build node-fibers against the custom Node.js headers
 RUN npm install --nodedir="/usr/src/node/node-install/usr/local"
+
+# Verify fibers native module loads correctly
+RUN node -e "const Fiber = require('./build/Release/fibers.node'); console.log('Fibers native module loaded successfully');"
+
+# Run tests
 RUN npm test || true
 RUN rm bin/repl
 RUN find .

Dockerfile.Node24

@@ -38,9 +38,11 @@ RUN update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-11 100
 WORKDIR /usr/src/node
 COPY . .
 
-# Disable maglev for fibers compatibility - maglev uses thread_local and stack manipulation
-# that conflicts with fiber context switching
-RUN ./configure --experimental-enable-pointer-compression --v8-disable-maglev
+# Configure Node.js for fibers compatibility:
+# - v8_enable_sandbox is already disabled in configure.py (required for ucontext stack switching)
+# - Do NOT enable pointer compression (unsupported without sandbox, adds ABI complexity)
+# - Disable maglev (its stack manipulation conflicts with fiber context switching)
+RUN ./configure --v8-disable-maglev
 RUN make -j4 install DESTDIR=./node-install
 
 CMD ["bash"]