Skip to content

Commit 539569d

Browse files
authored
[fix] Remove legacy warnings for mooncake upsert API (#91)
Signed-off-by: Teng Ma <stmatengss@gmail.com>
1 parent d147a33 commit 539569d

2 files changed

Lines changed: 7 additions & 15 deletions

File tree

tests/e2e/test_e2e_lifecycle_consistency.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -445,11 +445,6 @@ def test_core_consistency(e2e_client):
445445
def test_cross_shard_complex_update(e2e_client):
446446
"""Cross-shard update: put A + put B, update overlapping region, verify all regions."""
447447

448-
# FIXME: Add data update test to MooncakeStore after Upsert function is ready
449-
# https://github.com/kvcache-ai/Mooncake/issues/1645
450-
if os.environ.get("TQ_TEST_BACKEND", "SimpleStorage") == "MooncakeStore":
451-
return
452-
453448
client = e2e_client
454449
partition_id = "test_cross_shard_update"
455450
task_name = "cross_shard_task"

transfer_queue/storage/managers/mooncake_manager.py

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,19 @@
1616
from typing import Any
1717

1818
from transfer_queue.storage.managers.base import KVStorageManager, StorageManagerFactory
19-
from transfer_queue.utils.logging_utils import get_logger
2019
from transfer_queue.utils.zmq_utils import ZMQServerInfo
2120

22-
logger = get_logger(__name__)
23-
2421

2522
@StorageManagerFactory.register("MooncakeStore")
2623
class MooncakeStorageManager(KVStorageManager):
27-
"""Storage manager for MooncakeStorage backend."""
24+
"""Storage manager for MooncakeStorage backend.
2825
29-
def __init__(self, controller_info: ZMQServerInfo, config: dict[str, Any]):
30-
logger.warning(
31-
"MooncakeStore backend doesn't support key update (upsert) for now. "
32-
"You must delete the key before updating it. "
33-
"Refer to https://github.com/kvcache-ai/Mooncake/issues/1645 for details."
34-
)
26+
Key update (upsert) is supported natively via the MooncakeStore client's
27+
``batch_upsert_from`` (zero-copy tensor path) and ``upsert_batch`` (raw bytes
28+
path). See ``mooncake-integration/store/store_py.cpp`` upstream for the
29+
pybind bindings.
30+
"""
3531

32+
def __init__(self, controller_info: ZMQServerInfo, config: dict[str, Any]):
3633
config["client_name"] = "MooncakeStoreClient"
3734
super().__init__(controller_info, config)

0 commit comments

Comments
 (0)