-
Notifications
You must be signed in to change notification settings - Fork 28
[feat] Support store custom_meta in controller for backend-specific info #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4740782
1. add custom_meta to controller
tianyi-ge c267892
1. add custom_meta to controller
tianyi-ge 9a553b9
1. add tests for controller with custom meta
tianyi-ge 524154e
Merge branch 'feat/custom-meta' of github.com:tianyi-ge/TransferQueue…
tianyi-ge 3dee20c
revert unnecessary changes
tianyi-ge 9129765
fix minor code reviews
tianyi-ge a21ef48
fix unit test reviews
tianyi-ge 92c0305
fix minor reviews
tianyi-ge 3a16244
fix type check
tianyi-ge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this will happen since we strictly requires the shape of
custom_metato be exactly with number of samples (commented earlier)?