fix: combobox/menu items width (#2799)

fixes #2553

Signed-off-by: Arufonsu <17498701+Arufonsu@users.noreply.github.com>

Author: Arufonsu

Intersect.Client.Framework/Gwen/Control/ComboBox.cs

@@ -422,10 +422,8 @@ private static void Open(ComboBox @this)
         var menuItems = @this._menu.Children.OfType<MenuItem>().ToArray();
         foreach (var menuItem in menuItems)
         {
-            menuItem.SizeToContents();
+            menuItem.AutoSizeToContents = false;
             totalChildHeight += menuItem.OuterHeight;
-            // TODO(2553): I thought this was the solution, it isn't. Results in menu growing each time it's opened.
-            // width = Math.Max(width, menuItem.OuterWidth + menuPaddingH);
         }
 
         var offset = @this.ToCanvas(default);

Intersect.Client.Framework/Gwen/Control/ContextMenu.cs

@@ -1,23 +1,3 @@
 namespace Intersect.Client.Framework.Gwen.Control;
 
-public class ContextMenu : Menu
-{
-    public ContextMenu(Base parent, string? name = default) : base(parent, name)
-    {
-
-    }
-
-    protected override void OnPositioningBeforeOpen()
-    {
-        base.OnPositioningBeforeOpen();
-
-        SizeToChildren(recursive: true);
-    }
-
-    protected override void OnOpen()
-    {
-        base.OnOpen();
-
-        PostLayout.Enqueue(contextMenu => contextMenu.SizeToChildren(recursive: true), this);
-    }
-}
+public class ContextMenu(Base parent, string? name = default) : Menu(parent, name);

Intersect.Client.Framework/Gwen/Control/Menu.cs

@@ -193,7 +193,13 @@ private static void Open(Menu @this, Pos position)
 
     protected virtual void OnPositioningBeforeOpen()
     {
+        var menuItems = Children.OfType<MenuItem>().ToArray();
+        foreach (var menuItem in menuItems)
+        {
+            menuItem.AutoSizeToContents = false;
+        }
 
+        SizeToChildren(recursive: true);
     }
 
     protected virtual void OnOpen()