fix: restores proper prompt for item drag-and-drop

- Ensures all item drops go through TryDropItem, restoring the safety prompt that asks which item and how many to drop.
- Fixes a bug introduced with DragAndDrop_HandleDrop returning an incorrect boolean when bypassing the drop prompt, which caused undroppable items to have their icons hidden.

Author: Arufonsu

Intersect.Client.Core/Entities/Player.cs

@@ -415,7 +415,7 @@ public void TryDropItem(int inventorySlotIndex)
         }
 
         var quantity = inventorySlot.Quantity;
-        var canDropMultiple = quantity > 1;
+        var canDropMultiple = GetQuantityOfItemInInventory(itemDescriptor.Id) > 1;
         var inputType = canDropMultiple ? InputType.NumericSliderInput : InputType.YesNo;
         var prompt = canDropMultiple ? Strings.Inventory.DropItemPrompt : Strings.Inventory.DropPrompt;
         _ = new InputBox(

Intersect.Client.Core/Interface/Game/Draggable.cs

@@ -39,10 +39,7 @@ public override void DragAndDrop_StartDragging(Package package, int x, int y)
 
     public override void DragAndDrop_EndDragging(bool success, int x, int y)
     {
-        if (!success)
-        {
-            IsVisibleInParent = true;
-        }
+        IsVisibleInParent = !success;
     }
 
     public override bool DragAndDrop_HandleDrop(Package package, int x, int y)

Intersect.Client.Core/Interface/Game/Inventory/InventoryItem.cs

@@ -403,12 +403,6 @@ public override bool DragAndDrop_HandleDrop(Package package, int x, int y)
             return false;
         }
 
-        if (!Interface.DoesMouseHitInterface() && !player.IsBusy)
-        {
-            PacketSender.SendDropItem(SlotIndex, inventorySlot.Quantity);
-            return true;
-        }
-
         var targetNode = Interface.FindComponentUnderCursor();
 
         // Find the first parent acceptable in that tree that can accept the package
@@ -430,13 +424,12 @@ public override bool DragAndDrop_HandleDrop(Package package, int x, int y)
                     return true;
 
                 case BankItem bankItem:
-                    player.TryStoreItemInBank(
+                    return player.TryStoreItemInBank(
                         SlotIndex,
                         bankSlotIndex: bankItem.SlotIndex,
                         quantityHint: inventorySlot.Quantity,
                         skipPrompt: true
                     );
-                    return true;
 
                 case HotbarItem hotbarItem:
                     player.AddToHotbar(hotbarItem.SlotIndex, 0, SlotIndex);
@@ -452,7 +445,11 @@ public override bool DragAndDrop_HandleDrop(Package package, int x, int y)
             }
         }
 
-        // If we've reached the top of the tree, we can't drop here, so cancel drop
+        if (!Interface.DoesMouseHitInterface() && !player.IsBusy)
+        {
+            player.TryDropItem(SlotIndex);
+        }
+
         return false;
     }