fix: spell/item icon flicker after successful drag-drop

Stop restoring dragged icon visibility at the end of a successful drag-drop operation, since the item may have moved (e.g., inventory ↔ bank  // inventory ↔ drop item) and the server-driven slot update will refresh the correct icon state. This fixes a 1-frame flash where the source slot icon briefly reappears before disappearing again.

Author: Arufonsu

Intersect.Client.Core/Interface/Game/Draggable.cs

@@ -39,7 +39,10 @@ public override void DragAndDrop_StartDragging(Package package, int x, int y)
 
     public override void DragAndDrop_EndDragging(bool success, int x, int y)
     {
-        IsVisibleInParent = true;
+        if (!success)
+        {
+            IsVisibleInParent = true;
+        }
     }
 
     public override bool DragAndDrop_HandleDrop(Package package, int x, int y)

Intersect.Client.Core/Interface/Game/Inventory/InventoryItem.cs

@@ -477,6 +477,7 @@ private void PlayerOnInventoryUpdated(Player player, int slotIndex)
 
         // empty texture to reload on update
         Icon.Texture = default;
+        Icon.IsVisibleInParent = false;
     }
 
     public override void Update()

Intersect.Client.Framework/Gwen/DragDrop/DragAndDrop.cs

@@ -58,7 +58,7 @@ private static bool ShouldStartDraggingControl(int x, int y)
 
         // Not been dragged far enough
         var length = Math.Abs(x - sLastPressedPos.X) + Math.Abs(y - sLastPressedPos.Y);
-        if (length < 5)
+        if (length <= 1)
         {
             return false;
         }