Skip to content

fix: client DC when Input Variable event is sent empty #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Arufonsu merged 1 commit into from
Dec 21, 2025
Merged

fix: client DC when Input Variable event is sent empty #2781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Intersect.Server.Core/Entities/Player.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6980,8 +6980,9 @@ public void RespondToEventInput(Guid eventId, bool newValueBool, int newValue, s

break;
case VariableDataType.String:
if (newValueString.Length >= cmd.Minimum &&
newValueString.Length <= cmd.Maximum)
var stringValue = newValueString ?? string.Empty;
var stringLength = stringValue.Length;
if (stringLength >= cmd.Minimum && stringLength <= cmd.Maximum)
{
if (value.String != newValueString)
{
Expand Down
6 changes: 4 additions & 2 deletions Intersect.Server.Core/Networking/PacketHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1468,11 +1468,13 @@ public void HandlePacket(Client client, EventResponsePacket packet)
//EventInputVariablePacket
public void HandlePacket(Client client, EventInputVariablePacket packet)
{
client.Entity.RespondToEventInput(
var player = client?.Entity;

player?.RespondToEventInput(
packet.EventId,
packet.BooleanValue,
packet.Value,
packet.StringValue,
packet.StringValue ?? string.Empty,
packet.Canceled
);
}
Expand Down
Loading