there is something wrong in federated_main.py

[Mr-lq7]

the code should be the change to the place marked in the red box

[Mr-lq7]

Sorry, it should be :
for idx in idxs_users:

[duchoang06]

Agreed. Should be 'idx' instead of 'c'.

[OuyangWenyu]

https://github.com/AshwinRJ/Federated-Learning-PyTorch/blob/26eaec40fa8beb56777feb89756f6401c28c4736/src/federated_main.py#L100C43-L100C72 the comment is "over all users at every epoch", I guess it should be c, and the idxs should be user_groups[c]

[saigontrade88]

Hi,
To calculate the average training accuracy over all users (also known as the variable "idxs_users") participating in a training round, we should calculate the training accuracy of each user. We sum them up and divide the sum by the number of participants.

[saigontrade88]

@Mr-lq7 If you are clear, please close this issue. Thanks.