Skip to content

feat: support 'this' type on methods and properties#2906

Draft
mattjohnsonpint wants to merge 5 commits intoAssemblyScript:mainfrom
mattjohnsonpint:issue-2904
Draft

feat: support 'this' type on methods and properties#2906
mattjohnsonpint wants to merge 5 commits intoAssemblyScript:mainfrom
mattjohnsonpint:issue-2904

Conversation

@mattjohnsonpint
Copy link
Copy Markdown
Contributor

@mattjohnsonpint mattjohnsonpint commented Feb 5, 2025

Fixes #2904

Changes proposed in this pull request:

  • Fixes support for polymorphic this type on class methods and properties
  • Reports a "not implemented" for fields declared with the this type (would be nice, but is complicated)
  • Adds compiler tests for this feature

To clarify, the this type was already implemented, but was returning the base type instead of the calling instance type.

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

this type should return instance type when overridden

5 participants