feat: support 'this' type on methods and properties#2906
Draft
mattjohnsonpint wants to merge 5 commits intoAssemblyScript:mainfrom
Draft
feat: support 'this' type on methods and properties#2906mattjohnsonpint wants to merge 5 commits intoAssemblyScript:mainfrom
mattjohnsonpint wants to merge 5 commits intoAssemblyScript:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2904
Changes proposed in this pull request:
thistype on class methods and propertiesthistype (would be nice, but is complicated)To clarify, the
thistype was already implemented, but was returning the base type instead of the calling instance type.